Fix bugs when importing from git repo #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
DROP TABLE
toDELETE FROM
DROP vs DELETE
This addresses issue #40. An explanation can be seen in this comment on the issue. Essentially, dropping the table is more destructive than what is needed when replacing the entries with the data from the csv files saved in git. Using the
DELETE
command preserves references, triggers, and other important information on the table.Only modify if there is csv content
I was running into issues where the script would crash if there was no content in domainlist.csv and the script tried to import from it. Obviously, if there is no content in the file it doesn't need to be imported so I just added a check to see if there is anything in the file before attempting an import and modifying the table.
Ignore first line of csv when importing
The first line of the csv file should contain the column names from the SQL table. Skipping this line prevents errors and warnings when importing.
Add some semicolons
I was running into some strange issues with the if statements while making changes and adding these semicolons seemed to solve them.