feat(fzf-lua): add an input indicator after prompt #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Mar 13, 2024
lua/dressing/select/fzf_lua.lua
Outdated
| @@ -5,6 +5,9 @@ M.is_supported = function() | |||
| end | |||
|
|
|||
| M.select = function(config, items, opts, on_choice) | |||
| if opts.prompt then | |||
| opts.prompt = opts.prompt .. "> " | |||
There was a problem hiding this comment.
The default prompt has a : at the end, and I would expect that to be a common pattern. What do you think about just adding the space and not the >?
There was a problem hiding this comment.
It's up to you but I recommend (feel free to edit on this branch), in any fzf prompt, the separator is always '>' and never :, including standalone fzf, and the same is true for all fzf-lua's built-in search commands.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fzf_lua shows its prompt and user input in the same line and dressing.nvim tries to make prompts like the title of a window, so it causes the prompt and input to be crowded together.
Description
I suggest adding a separator after the prompt.