-
Notifications
You must be signed in to change notification settings - Fork 9
Add greenvars script and sprites, works for previewing on somebot web #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
http://unfortunate-maps.jukejuice.com/show/1 great job guys! I'll poke around on the site this week. I think greenvars showed some interest too so not sure if he wants to work on anything too. |
|
noticed, that i'll have to update the google key at some point, i'll try to do this monday but if i forget, remind me |
|
Thanks for loading it up steppin. It seems like everything from /static/tagpro-map-editor/ isn't being forwarded properly. This worked when I just used flask, but maybe it's an issue with flask/nginx. Is there any way to have nginx forward the static files? |
|
what's the next step for this? You guys want to announce on the sub and ask people to file bugs here? Or are there bugs we should work on first? I can help out with this too |
|
There's a couple easy fixers. Wait for a few more days until I can find some time to fix some stuff that I have in mind (indication, and whatever). |
|
sure no problem, just ping if you need anything |
|
A few things with the previews need to be addressed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this wrong it should read (It moves clockwise):
CORDS GO (TOPLEFT, TOPRIGHT, BOTTOMRIGHT, BOTTOMLEFT)
|
greenvars, hit me up on irc and we'll go over some of the basics with git; I'm cool with giving you write access to the repo but it might be better to do it via pull requests at first until you get more comfortable with git |
Greenvar's thing worked, but it broke the API. Add a new function "preview45", so everything that referenced previewer.preview and whatever still worked. It might not be as robust, but it works and will get the functionality into somebot so we can find what breaks.
This definitely isn't as nice, because the texture pack needs to be broken into sprites, rather than using a flat png, but for the moment this might be acceptable. Someone could make a script that takes in a texture pack and outputs the correct sprites if the sprite-route is the correct way to go.