New Previewer in some_bot system #23
Conversation
This is my attempt at putting the new previewer in some_bot. I don't know anything about sys.args and some python 2 things but its a start. I commented anything I'm not sure on.
|
Am I supposed to put something here? GitHub is fancy. |
|
Oh gosh I'm probably ruining everything |
Added line to generate image to paste on
|
thanks! Haven't forgotten about this |
I finally read the part in my book on classes and methods and such. I went through my previous version and made it work. I'm almost completely positive this will work with no issues and will generate previews. Object-Oriented and everything. CHANGES: Put class specific variables in the __init__ The dictionary of cords and what sprite they are is now generated in its own function Changed several variable names as map was used too much Draw no longer needs parameters Took adj_walls out of the plot class Added some debug data in __str__ Final Concerns: Will the previews work in some_bot and JukeJuice? Shouldn't the png mode be RGB and not RGBA? I think RGBA gives a 4th tuple value which messes up the program but ill leave it up to you. Are variables in the right scope? I'm horrible at github so these commit changes might look weird but who needs previous versions when this works?
|
Forgot to put this in here in case the commit changes are too hard to read. |
After doing a few more tests and actually trying it on my own computer I have finished. I put adj walls back into the plot class because it uses class attributes. I also fixed a few typos and missed places where self should be. I'm learning so much. This is most definitely the final version.
|
can you include the sprites/resources in your PR? |
|
I have no idea how to upload each sprite to be merged in a repository. I do have a nice zip with all the pngs with correct file names I sent you in a message a while back. |
|
ok, do you still have that link? |
I don't know if this will ever happen but now the previewer will never fail to display a tile if there's an odd assortment of tiles around it.
|
oh hey, you are still working on this. I tried pulling this in a few days ago but paused and shifted to web stuff because:
But it is still on my list of TODOs, it's just that without a clean pull request, it's not going to be a speedy thing for me :/ |
|
Can you stfu steppin thanks
|
|
lol wrong issue... I'll move stuff... |
2 participants
This is my attempt at putting the new previewer in some_bot. I don't know anything about sys.args and some python 2 things but its a start. I commented anything I'm not sure on.