Prevent pages from other accounts from loading#19
Open
thedewil wants to merge 1 commit intostephenou:masterfrom
Open
Prevent pages from other accounts from loading#19thedewil wants to merge 1 commit intostephenou:masterfrom
thedewil wants to merge 1 commit intostephenou:masterfrom
Conversation
Check /api/v3/getPublicPageData and compare "spaceDomain" with local variable.
|
This will address issue #45. |
|
It would be even better if instead of throwing an error it landed on a custom 404 page. |
Owner
|
unfortunately returning an error from https://square-glade-e805.stephenou.workers.dev/ (I used a random string for #18 doesn't work either because the Anyone has a better idea? |
|
Rather than checking getPublicPageData API the notion site domain can be used instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Check /api/v3/getPublicPageData and compare "spaceDomain" with local variable.