Skip to content

Fix case insensitivity in ContainsProfanity #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrianHendrickson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix case insensitivity in ContainsProfanity #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ProfanityFilter.Tests.Unit/ProfanityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,5 +898,14 @@ public void ContainsProfanityReturnsTrueWhenProfanityIsADollarDollar()

Assert.IsTrue(result);
}

[TestMethod]
public void ContainsProfanityReturnsTrueWhenProfanityIsVariableCase()
{
var filter = new ProfanityFilter();
var result = filter.ContainsProfanity("Fuck");

Assert.IsTrue(result);
}
}
}
4 changes: 2 additions & 2 deletions ProfanityFilter/ProfanityFilter/ProfanityFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ public bool ContainsProfanity(string term)
return false;
}

Regex regex = new Regex(string.Format(@"(?:{0})", string.Join("|", potentialProfanities).Replace("$", "\\$"), RegexOptions.IgnoreCase));
string regexPattern = string.Format(@"(?:{0})", string.Join("|", potentialProfanities).Replace("$", "\\$"));

foreach (Match profanity in regex.Matches(term))
foreach (Match profanity in Regex.Matches(term, regexPattern, RegexOptions.IgnoreCase))
{
// if any matches are found and aren't in the allowed list, we can return true here without checking further
if (!AllowList.Contains(profanity.Value.ToLower(CultureInfo.InvariantCulture)))
Expand Down