Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional max guards for MSVC #1630

Merged

Conversation

llm96
Copy link
Contributor

@llm96 llm96 commented Feb 21, 2025

Copied the fix from 430f67c to the other ones I ran into today. Fixes some compiler errors on MSVC

.\glaze\include\glaze/util/parse.hpp(1284): error C2589: '(': illegal token on right side of '::'
.\glaze\include\glaze/util/parse.hpp(1284): error C2760: syntax error: '(' was unexpected here; expected ')'
.\glaze\include\glaze/util/parse.hpp(1284): error C2760: syntax error: ')' was unexpected here; expected 'expression'
.\glaze\include\glaze/util/parse.hpp(1284): error C2760: syntax error: ')' was unexpected here; expected ';'
.\glaze\include\glaze/util/parse.hpp(1284): error C3878: syntax error: unexpected token ')' following 'expression_statement'
.\glaze\include\glaze/util/parse.hpp(1284): error C3878: syntax error: unexpected token ')' following 'statement'
.\glaze\include\glaze/util/parse.hpp(1284): error C3878: syntax error: unexpected token ')' following 'statement_seq'
.\glaze\include\glaze/util/parse.hpp(1284): note: missing one of:  '}' ?
.\glaze\include\glaze/util/parse.hpp(1284): error C2760: syntax error: ')' was unexpected here; expected '}'
.\glaze\include\glaze/util/parse.hpp(1284): error C3878: syntax error: unexpected token ')' following 'compound_statement'
.\glaze\include\glaze/util/parse.hpp(1284): error C3878: syntax error: unexpected token ')' following 'selection_statement'
.\glaze\include\glaze/util/parse.hpp(1284): note: error recovery skipped: ') >'
.\glaze\include\glaze/util/parse.hpp(1284): note: error recovery skipped: ') ) ?'
.\glaze\include\glaze/util/parse.hpp(1284): note: error recovery skipped: ') :'
.\glaze\include\glaze/util/parse.hpp(1284): note: error recovery skipped: ') ) )'
.\glaze\include\glaze/util/parse.hpp(1286): error C2065: 'limit': undeclared identifier
.\glaze\include\glaze/util/parse.hpp(1291): error C2065: 'S': undeclared identifier
.\glaze\include\glaze/util/parse.hpp(1291): error C2187: syntax error: 'S' was unexpected here
.\glaze\include\glaze/util/parse.hpp(1291): error C2760: syntax error: '>' was unexpected here; expected ')'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token '(' following 'expression'
.\glaze\include\glaze/util/parse.hpp(1291): note: error recovery skipped: '( identifier'
.\glaze\include\glaze/util/parse.hpp(1291): error C2760: syntax error: ')' was unexpected here; expected ';'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token ')' following 'expression_statement'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token ')' following 'statement'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token ')' following 'statement_seq'
.\glaze\include\glaze/util/parse.hpp(1291): note: missing one of:  '}' ?
.\glaze\include\glaze/util/parse.hpp(1291): error C2760: syntax error: ')' was unexpected here; expected '}'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token ')' following 'compound_statement'
.\glaze\include\glaze/util/parse.hpp(1291): error C3878: syntax error: unexpected token ')' following 'selection_statement'
.\glaze\include\glaze/util/parse.hpp(1291): note: error recovery skipped: ') )'

@stephenberry
Copy link
Owner

Thanks for this!

@stephenberry stephenberry merged commit e3ccdef into stephenberry:main Feb 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants