Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enforce-slot-jsdoc rule #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcfranco
Copy link
Contributor

@jcfranco jcfranco commented Mar 6, 2024

Related issue: #91

Adds rule to ensure slots are both used in rendering and documented.

Note: this rule requires slot rendering and name assignment to be static.

@jcfranco jcfranco mentioned this pull request Mar 6, 2024
3 tasks
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very useful to me, thanks for raising the PR @jcfranco. Mind rebasing on top of current main branch? Once the pipelines pass I would be happy to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants