chore(testing): Extends Coverage #2 #6468
Merged
+5,043
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate as part of your baseClass
… override, and method composition.
…thod inheritance.
…ers with automatic lifecycle hooking
… type in inheritance chains Test Case stenciljs#13 - Decorator Conflicts Features: - Duplicate @prop names (component overrides base) - Duplicate @State names (component overrides base) - Duplicate @method names (component overrides base) - Compiler precedence rules (component decorators take precedence)
Test Case stenciljs#10 - Event Handling Inheritance Features: - Inherits base class window/document/host listeners - Handles child class window/document/host listeners - Child override event handler takes precedence over base - Handles event bubbling correctly - Tracks events in combined event log
Test Case stenciljs#11 - Watch Decorator Inheritance Features: - Inherits base class @watch decorators - Handles child class @watch decorators - Executes watch handlers in correct order (base first, then child) - Child override watch handler takes precedence over base - Reactive property chains work correctly - Tracks watch calls in combined watch log
…rollers Test Case stenciljs#15 - Inheritance-Based Scaling Features: - 3 components (TextInput, RadioGroup, CheckboxGroup) using inheritance - 2 controllers (ValidationController, FocusController) via inheritance - Lifecycle methods called correctly - Validation triggers on blur - Focus tracking works - Controllers use inheritance pattern
…rollers Test Case stenciljs#16 - Composition-Based Scaling Features: - 3 components (TextInput, RadioGroup, CheckboxGroup) using composition - 2 controllers (ValidationController, FocusController) via composition - Lifecycle methods called automatically via ReactiveControllerHost - Validation triggers on blur - Focus tracking works - Controllers are properly composed (not inherited)
OS-jacobbell
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The
extendsfunctionality for Stencil components (allowing component classes to extend from other Stencil-decorated base classes) lacked comprehensive test coverage. While basic functionality existed, there were no detailed test cases demonstrating:What is the new behavior?
With this PR there is now complete test coverage for the extends functionality, including detailed test cases demonstrating how you can move logic out of the Component into a separate Controller class either relying purely on inheritance or using a combo of inheritance & composition, as well as edge cases.
Documentation
https://paulvisciano.github.io/stencil-core/?path=/docs/testing-behavior-extends-overview--docs
Does this introduce a breaking change?
Testing
During local testing I have ran into some concurrency issues, most likely due to resource constraints (running too many workers). When I have tried to run the tests in isolation they all pass. Hoping none of those are present in CI.
Other information