feat(compiler): allow dash-case type generation to be disabled #6179
+129
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generation Allows for `noDashCaseTypes` to be set in Config to prevent generation of non-camelCase types from attribute names in `components.d.ts` during build. fixes: stenciljs#6178 feat: allow dash-case type generation to be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
#6158 added support for dash-casing by generating dash-cased properties from attribute names and adding them to
components.d.ts(marking them as deprecated).This is not always needed (or desired) in projects that were not affected by #6150
fixes #6178
GitHub Issue Number: #6178
What is the new behavior?
noDashCaseTypeshas been added as an optional config property. If set totrue, dash-cased attribute names/types will not be added to thecomponents.d.tson build. By default this property is set tofalse.Documentation
Does this introduce a breaking change?
Testing
A test case has been added to
generate-app-types.spec.tsThis has also been tested against a Stencil project.
I haven't added a new e2e test, but can do so if needed.
Other information