-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Horizon calls with RPC #93
Conversation
…e-horizon # Conflicts: # internal/tss/services/transaction_service.go # internal/tss/services/transaction_service_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good! Just a couple minor comments and one more meaningful question.
One thing to note here is that if we are using RPC, we need to be sure that it is healthy (ie gethealth returns a positive result), which can take upto a few minutes if I'm not mistaken. So you may not be able to create all those channel accounts as soon as wallet backend starts up - you'd have to wait till RPC is ready to create those channel accounts right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take a look at my comments
What
Why
Horizon is huge monolith that is very hard to maintain and this PR is part of org wide effort to move away from Horizon and use RPC instead which is very lightweight and easier to run than Horizon.
Known limitations
N/A
Issue that this PR addresses
Closes #75
Checklist
PR Structure
all
if the changes are broad or impact many packages.Thoroughness
Release