Add prometheus metrics for monitoring #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Is this pr capturing all the metrics listed in the https://docs.google.com/document/d/1xx0srb5MnVaK4x8cjQniauKsDroKEzL841yVmBfXYZk/edit?tab=t.0#heading=h.5lnmdqf1727m or is that coming in a future pr?
@gouthamp-stellar Yes due to lot of metrics, I will break it into smaller PRs |
| if cfg.MetricsService != nil { | ||
| cfg.MetricsService.RegisterPoolMetrics(WebhookChannelName, pool) | ||
| } | ||
| return webhookPool | ||
| } | ||
|
|
There was a problem hiding this comment.
Are we logging stats like when we have send success/failure to the webhook?
|
@aditya1702 if this is ready to merge, lets do it. I removed the requirement of reviews for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
apiandingestservices. Note that while the prometheus servers are separate, the metrics are collected on the same grafana server.Why
We want to setup a proper monitoring framework for the wallet-backend.
Known limitations
NA
Issue that this PR addresses
Closes #99
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release