Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress class to ingress-private from private #232

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

satyamz
Copy link
Contributor

@satyamz satyamz commented Dec 18, 2024

What:

Update ingress class to ingress-private from private

Why:

We are migrating to upstream ingress controller. We have installed upstream ingress controller to all clusters. New class name for private ingress controller is ingress-private

Issue:

https://github.com/stellar/ops/issues/3412

@satyamz
Copy link
Contributor Author

satyamz commented Dec 18, 2024

@jayz22 Thanks for the review. Can you please merge this PR?

Copy link
Contributor

@jayz22 jayz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default command option also needs to be changed:

In Programe.fs

    [<Option("ingress-class",
             HelpText = "Value for kubernetes.io/ingress.class, on ingress",
             Required = false,
             Default = "private")>]

and

                  logLevels = ll
                  ingressClass = "private"
                  ingressInternalDomain = "local"

@jayz22
Copy link
Contributor

jayz22 commented Dec 18, 2024

The default command option also needs to be changed:

In Programe.fs

    [<Option("ingress-class",
             HelpText = "Value for kubernetes.io/ingress.class, on ingress",
             Required = false,
             Default = "private")>]

and

                  logLevels = ll
                  ingressClass = "private"
                  ingressInternalDomain = "local"

All the stellar-supercluster Jenkins missions uses default class name so if you update it they will work fine.

@jayz22 jayz22 merged commit d677e5b into stellar:main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants