Skip to content

📝 Refresh six classic guides #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 130 commits into
base: main
Choose a base branch
from

Conversation

JFWooten4
Copy link
Contributor

@JFWooten4 JFWooten4 commented Jun 26, 2024

Solving #338 🤝

@JFWooten4 JFWooten4 marked this pull request as draft June 26, 2024 14:12
JFWooten4 added a commit to JFWooten4/stellar-docs that referenced this pull request Apr 16, 2025
I'll polish this off in stellar#723
This way only runs the Husky pre-commit if you have yarn installed, which should help with stellar#1044 compatability, given those with write access can quickly (via bot?) run the formatting. i had a lot of problems with this three weeks ago when editing on an offline laptop that didn't have all the dependencies involved. Even though I was going to take care of the nuances on this main desktop here, I couldn't synch up my work to the branch, and thus it was hard to manually override the git commit checks.
Husky changes here should respect stellar#96 given the autochecks run formatter and fail if not prettier at `check MDX` step
JFWooten4 added 10 commits May 14, 2025 01:19
Also removes  a lot of redundant language from the intent of d5ff964
also bypass the check if yarn run fails for reasons unrelated to file issues like Node version mismatch or corrupt environment
This gets into how deeply we want  to epxlain paths in stellar#1545
This cleans up the wording around stellar#1061 without reviewing the pages we notify users about `consistency`.

I think a better long-term solution is a "Consistency" flag added to the affected endpoint pages. This could be a simple button akin to the "Supports Streaming" info box. However, even that seems a verbose solution which would also do well to exist as a simple button (akin to  ledgerStorage) > two sentences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants