Add dev containers#1514
Conversation
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
|
sweet! thanks for the PR! is there a way i can test it out in a codespace using this branch (probably a dumb question lol)? |
Replace [Branch name or commit hash] with your desired value! https://codespaces.new/stellar/stellar-docs/tree/[Branch name or commit hash] |
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
this seems like a great start to the effort! left a couple questions/notes on the devcontainer file.
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
|
@briwylde08 @ElliotFriend Ok fiddled with the commands so it's much more clear what is happening. Devcontainers is VERY PARTICULAR about command ordering but I think it's pretty solid now. I also added a devcontainers.md that auto-opens to kinda orient people to what's going on. 
|
anataliocs
added
documentation
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
lookin' good! left a couple questions that might be dumb lol
thanks for the work!
| "start-bg": "nohup yarn start --port 3000 > docs.log 2>&1 & echo $! > run.pid", | ||
| "dc-process": "echo Docusaurus running on process: $(cat run.pid)", | ||
| "dc-start": "yarn start-bg && yarn dc-process", | ||
| "dc-stop": "kill -9 $(lsof -t -i:3000)", | ||
| "dc-restart": "yarn dc-stop && yarn dc-start", |
There was a problem hiding this comment.
to be honest, i'm a bit hesitant to add more scripts here. it's probably already a little too crowded and could use some cleaning up lol.
is there a way we can put these into the devcontainer.json file, where they might be a little more "at home"?
There was a problem hiding this comment.
Yea I can move them to shell scripts, package.json is crowded already
| }, | ||
| "extensions": [ | ||
| "dbaeumer.vscode-eslint", | ||
| "orta.vscode-jest", |
There was a problem hiding this comment.
i don't think we use jest in this repo. do we need it in the devcontainer?
There was a problem hiding this comment.
Oh yea nice call out thank you!
|
Preview is available here: |
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
looks good to me! thanks for all the work on this! I left one nitpick-y comment that you're free to ignore if you want.
Is this one ready, or do you have more work to do on it?
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
nit: got some extra blank lines here at the end.
There was a problem hiding this comment.
Best practice on github is to use the suggestion feature for minor 1 line changes
|
Preview is available here: |
3 participants
Run Docs in Devcontainer. #1512
Features:
Testing steps: