Evict persistent entries to Hot Archive #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
persitent-eviction
branch
from
48998cb to
afe423d
Compare
dmkozh
reviewed
Dec 19, 2024
dmkozh
previously approved these changes
Jan 3, 2025
SirTyson
force-pushed
the
persitent-eviction
branch
from
d23a282 to
f9afcf4
Compare
dmkozh
approved these changes
Jan 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
# Description Resolves #4584 This PR adds support for the Hot Archive to TX apply. Specifically, `InvokeHostFunctionOp` will check both the live BucketList and Hot Archive BucketList for archived entries. The `RestoreFootprintOp` can now restore entries from both the live BucketList and Hot Archive. Additionally, restore meta has also changed for p23. The `LEDGER_ENTRY_RESTORED` type has been added for the restore op. When an entry is restored. both the `LedgerEntry` of the restored data and the corresponding `TTL` entry are emitted as `LEDGER_ENTRY_RESTORED LedgerEntryChangeType`. If the entry has not yet been evicted (such that the entry and it's TTL still exist in the live BucketList), the preexisting TTL value will be emitted as `LEDGER_ENTRY_STATE`. If the entry has been evicted such that the TTL value has been previously deleted, only a single change type of `LEDGER_ENTRY_RESTORED` will be emitted for the new value. For the data being restored, `LEDGER_ENTRY_STATE` is never emitted. Rebased on #4585. # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4395
This PR evicts persitent entries to the Hot Archive in p23. Specifically, the background eviction scan will delete expired persistent entries from the live bucketlist and add them to the hot archive. This change also includes eviction meta for these types.
Operations have not yet been modified to work with the evicted entries. This means that
InvokeHostFunctionOpdoes not check the hot archive for the existence of archived entries, andRestoreFootprintOpwill not be able to restore evicted entries. These changes will be added in a follow up PR.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)