Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for cursors #4580

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Drop support for cursors #4580

merged 1 commit into from
Dec 20, 2024

Conversation

marta-lokhova
Copy link
Contributor

@marta-lokhova marta-lokhova commented Dec 17, 2024 •
edited
Loading

Resolves #4418

This is a breaking change, however it should have no impact downstream as cursors have been deprecated for years at this point.

@marta-lokhova marta-lokhova self-assigned this Dec 17, 2024
@marta-lokhova marta-lokhova force-pushed the removeSupportForCursor branch 4 times, most recently from 3800ef3 to cab1a43 Compare December 17, 2024 02:47
graydon
graydon reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enthusiastic approval in principle! But before we merge I think we ought to do that thing we've been discussing where we do an extra round of definite signoffs on potentially affected downstream parties, regardless of deprecation notice.

@marta-lokhova marta-lokhova force-pushed the removeSupportForCursor branch 2 times, most recently from cafe879 to e3c9dc1 Compare December 17, 2024 18:08
@SirTyson SirTyson self-requested a review December 17, 2024 21:46
SirTyson
SirTyson approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@SirTyson SirTyson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I appreciate the fiery death of sql (after checking in with the relevant authorities)

@graydon graydon self-requested a review December 19, 2024 23:30
@graydon graydon enabled auto-merge December 19, 2024 23:30
@graydon graydon disabled auto-merge December 19, 2024 23:30
@graydon graydon enabled auto-merge December 19, 2024 23:37
@graydon graydon added this pull request to the merge queue Dec 20, 2024
Merged via the queue into stellar:master with commit 4729b41 Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson SirTyson approved these changes

@graydon graydon graydon approved these changes

Assignees

@marta-lokhova marta-lokhova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cursor support in core
3 participants
@marta-lokhova @graydon @SirTyson