Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Soroban loadgen/test fixes. #4578

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Dec 17, 2024

Description

  • Increase the refundable fee for Wasm uploads
  • Revert the accidental default instructions change
  • Add some fixes to the loadgen test to (hopefully) ensure there are no failures

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

SirTyson
SirTyson previously approved these changes Dec 17, 2024
Copy link
Contributor

@SirTyson SirTyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Increase the refundable fee for Wasm uploads
- Revert the accidental default instructions change
- Add some fixes to the loadgen test to (hopefully) ensure there are no failures
- Bump base instructions to 2.5M to account for the increased wasm size.
@dmkozh dmkozh added this pull request to the merge queue Dec 19, 2024
Merged via the queue into stellar:master with commit aa14685 Dec 19, 2024
13 checks passed
@dmkozh dmkozh deleted the loadgen_fixes branch December 19, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants