-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SQL for (most) Ledger State #4575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
remove-sql-2
branch
from
December 13, 2024 21:06
72b473f
to
0b4b104
Compare
SirTyson
force-pushed
the
remove-sql-2
branch
from
December 14, 2024 00:05
0b4b104
to
da4b3d5
Compare
marta-lokhova
previously approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice to see so much legacy code go away, thank you! I left a few questions wrt the migration, and a couple of minor nits. Otherwise happy to merge this asap.
Merged
SirTyson
force-pushed
the
remove-sql-2
branch
from
December 18, 2024 01:01
1a8e57f
to
09bb518
Compare
marta-lokhova
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4503 and #4502
This change removes SQL support for all ledger state, except for the offers table. It also enforces background eviction. In order to not break Horizon, core will not crash if any of the old flags or config settings are used. Instead it will print a warning and ignore the flags. The flags should be removed in the next protocol release.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)