Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BucketList cache #4565

Closed
wants to merge 2 commits into from
Closed

BucketList cache #4565

wants to merge 2 commits into from

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Dec 6, 2024

Description

Resolves #3696

This adds a persistent cache to BucketListDB at the bucket level. If a bucket is small, the entire bucket contents are cached in memory. For larger buckets, a random eviction cache is used instead.

Currently in draft form for max TPS tests, as I need to clean up the BucketIndex classes given that there's a fair bit of dead code now that caches are used.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson
Copy link
Contributor Author

Closing prototype, #4630 has a prod ready verison.

@SirTyson SirTyson closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add persistent cache to BucketListDB
1 participant