Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evict persistent entries to Hot Archive during eviction scans #4395

Closed
Tracked by #4392
SirTyson opened this issue Jul 19, 2024 · 0 comments · Fixed by #4585 · May be fixed by #4498
Closed
Tracked by #4392

Evict persistent entries to Hot Archive during eviction scans #4395

SirTyson opened this issue Jul 19, 2024 · 0 comments · Fixed by #4585 · May be fixed by #4498
Assignees

Comments

@SirTyson
Copy link
Contributor

No description provided.

@SirTyson SirTyson self-assigned this Jul 23, 2024
@SirTyson SirTyson linked a pull request Oct 29, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2025
# Description

Resolves #4395

This PR evicts persitent entries to the Hot Archive in p23.
Specifically, the background eviction scan will delete expired
persistent entries from the live bucketlist and add them to the hot
archive. This change also includes eviction meta for these types.

Operations have not yet been modified to work with the evicted entries.
This means that `InvokeHostFunctionOp` does not check the hot archive
for the existence of archived entries, and `RestoreFootprintOp` will not
be able to restore evicted entries. These changes will be added in a
follow up PR.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant