Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.0.0 #156

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Bump version to 2.0.0 #156

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924a3ef
Bump version to 1.8.0
philipliu Nov 14, 2024
b7f67e8
Bump version to 2.0
philipliu Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ val jvmVersion = JavaVersion.VERSION_11

allprojects {
group = "org.stellar.wallet-sdk"
version = "1.7.2"
version = "1.8.0"
Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be major or patch? I think this can break the application that relies on 0.44.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to start lining up the release numbers with the typescript-wallet-sdk https://github.com/stellar/typescript-wallet-sdk/releases/tag/v1.8.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily think we want to align versions with the wallet SDK. We can either make new wallet SDK version 2.0 or 1.8 but I vote for 1.8: we did some small breaking previously in minor versions, and I think it should be fine, given the scope of usage.

Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it breaks the backward compatibility, we should increment the major version according to semver.

This version bump breaks the compatibility by causing the java-stellar-sdk dependency conflicts.

Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket ANCHOR-865 is designed to prevent the dependency conflicts.

A PR draft is created: [PR-157]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped the version to 2.0

}

subprojects {
Expand Down