Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Horizon.Server.root to obtain information from the Horizon root endpoint. #1122

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Added Horizon.Server.root to obtain information from the Horizon root endpoint. #1122

merged 3 commits into from
Dec 16, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Dec 15, 2024

Resolve #1121

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2024
View reviewed changes
test/unit/server/horizon/server_test.js Dismissed Show dismissed Hide dismissed
@overcat overcat changed the title Add an interface to obtain information from the Horizon root endpoint. Added Horizon.Server.root to obtain information from the Horizon root endpoint. Dec 15, 2024
@overcat
Copy link
Contributor Author

overcat commented Dec 15, 2024

We need to use this feature, and it would be even better if a new version could be released.

Shaptic
Shaptic reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just be achieved by axios.get(SERVER_URL), right? Is the goal to add the schema to the API? If so this certainly makes sense to add.

test/unit/server/horizon/server_test.js Outdated Show resolved Hide resolved
@overcat
Copy link
Contributor Author

overcat commented Dec 16, 2024

This could just be achieved by axios.get(SERVER_URL), right? Is the goal to add the schema to the API? If so this certainly makes sense to add.

Hi @Shaptic,

Yes, these days I am trying to add support for Stellar in Trezor Suite. It requires obtaining the root information from the Horizon Server. Trezor Suite provides a wrapper that can directly wrap SDK.Horizon.Server. If this interface is not available, I would need to wrap SDK.Horizon.Server myself first and then have it wrapped by the Trezor Suite wrapper; if this interface is available, things will be much simpler.

Shaptic
Shaptic approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I can do a release by EOD

@Shaptic Shaptic merged commit 3988271 into stellar:master Dec 16, 2024
11 checks passed
@Shaptic Shaptic mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an interface to obtain information from the Horizon root endpoint.
2 participants
@overcat @Shaptic