Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature to pass key pair #1108

Closed

Conversation

od-hunter
Copy link

No description provided.

@od-hunter
Copy link
Author

od-hunter commented Nov 15, 2024

Fixes #1063

@chadoh , @Shaptic , please review

@od-hunter
Copy link
Author

@chadoh , @Shaptic please review o

@od-hunter
Copy link
Author

@chadoh , @Shaptic please review

@od-hunter
Copy link
Author

@chadoh , @Shaptic I’ve fixed linting issue please review

throw new Error("Could not extract the method name from the transaction envelope.");
throw new Error(
"Could not extract the method name from the transaction envelope."
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are clearly still many changes in this PR exclusively related to formatting. It makes it very hard to safely check the actual changes relevant to the issue at hand. Please check out the repository, ONLY add your changes, then commit and push those. Do not run any sort of formatter, automatic or otherwise. We cannot review or merge if there are many many lines which just change the code formatting.

@od-hunter
Copy link
Author

@chadoh , @Shaptic please review

@od-hunter
Copy link
Author

@Shaptic , @chadoh please review

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems like you're having some trouble here. @Shaptic I think we can close this PR and let someone else work on the issue.

@od-hunter
Copy link
Author

Sorry, it seems like you're having some trouble here. @Shaptic I think we can close this PR and let someone else work on the issue.

No please, let me try again🙏🏻 @chadoh

@od-hunter od-hunter closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants