Create Icon component #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CassioMG
reviewed
Mar 6, 2025
Comment on lines
+2365
to
+2366
| width: ${({ size }: { size: number }) => size * 1.5}px; | ||
| height: ${({ size }: { size: number }) => size * 1.5}px; |
There was a problem hiding this comment.
I think we should wrap those with px() instead of the inline px string so it resizes accordingly.
CassioMG
reviewed
Mar 6, 2025
| } | ||
|
|
||
| const iconElement = ( | ||
| <IconSvg width={size} height={size} color={color} testID={testID} /> |
There was a problem hiding this comment.
same thing here, I think we should do pxValue(size) to resize accordingly
There was a problem hiding this comment.
my bad! I forgot about this function
CassioMG
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #10
This PR add a Icon component that can be used like this:
The icons were imported from the SDS.
Samples: