feat(a11y): add automated axe checks for Dashboard, Bridges, Watchlist - #32
Merged
Meshmulla merged 1 commit intoAug 29, 2026
Conversation
…t, Alerts (stellar-kracken#27) - Wire vitest-axe toHaveNoViolations matcher into shared test setup (src/test/setup.ts) - Add TypeScript augmentation for toHaveNoViolations across the suite (src/test/vitest-axe.d.ts) - Add axe assertions for the four highest-traffic pages: - src/pages/Dashboard.a11y.test.tsx — mocks all heavy sub-components/hooks, 15s timeout for complex page scan - src/pages/Bridges.a11y.test.tsx — mocks hooks and store selectors, verifies rendered bridge grid - src/pages/Watchlist.a11y.test.tsx — covers empty state and populated state - src/pages/Alerts.a11y.test.tsx — covers loaded and loading states via useIncidentFeed mock - Fix axe violations surfaced on first pass: - src/components/alerts/CompactAlertList.tsx: promote role=table to role=grid, add role=columnheader/gridcell to all header/data cells, add aria-sort to column headers, add aria-label to sort buttons, mark decorative SVG arrows aria-hidden - src/components/BridgeStatusCard.tsx: replace h3 with p to remove heading-order violation inside card - All four pages pass toHaveNoViolations with no suppressions - Tests run automatically under the existing Unit tests CI step
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27