fix(browser): stabilize ChatGPT model selection in localized UIs#118
Open
dedene wants to merge 1 commit intosteipete:mainfrom
Open
fix(browser): stabilize ChatGPT model selection in localized UIs#118dedene wants to merge 1 commit intosteipete:mainfrom
dedene wants to merge 1 commit intosteipete:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the browser mode for oracle was (at least on my side) no longer working with the current ChatGPT interface: the flow gets stuck on the model selection dropdown opening/closing in an endless loop. Also I had to change localization to English before to get it working.
This is my attempt to fix this. Any feedback is welcome! 🙏
Summary
data-testidvalues and selected-row markers when matching the current modelChatGPTVerification
pnpm vitest run tests/browser/modelSelection.test.tspnpm buildpnpm run oracle -- --engine browser --browser-attach-running --browser-timeout 45s --model gpt-5.4 --prompt "Reply with the exact word ok" --verbosepnpm run oracle -- --engine browser --browser-attach-running --browser-timeout 45s --model gpt-5.4-pro --prompt "Reply with the exact word ok" --verboseNotes