fix(auth): clean up config.json entries on auth remove#467
Open
mvanhorn wants to merge 1 commit intosteipete:mainfrom
Open
fix(auth): clean up config.json entries on auth remove#467mvanhorn wants to merge 1 commit intosteipete:mainfrom
mvanhorn wants to merge 1 commit intosteipete:mainfrom
Conversation
When running `gog auth remove`, stale account_aliases and account_clients entries were left in config.json after the keyring token was deleted. This adds a config.UpdateConfig() call that removes alias entries pointing to the removed email and the account_clients entry for that email. Fixes steipete#466 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gog auth removenow cleans upaccount_aliasesandaccount_clientsentries in config.json when removing an account. Previously only the keyring token was deleted, leaving stale references.Changes
In
internal/cmd/auth_accounts.go, added aconfig.UpdateConfig()call afterstore.DeleteToken()that:credentials.json(shared across accounts)Testing
Added test in
auth_cmd_test.goverifying config cleanup after auth remove.Existing auth tests pass.
Fixes #466
This contribution was developed with AI assistance (Claude Code).