feat: subcommand-level allowlist for --enable-commands#218
Closed
EricYangTL wants to merge 2 commits intosteipete:mainfrom
Closed
feat: subcommand-level allowlist for --enable-commands#218EricYangTL wants to merge 2 commits intosteipete:mainfrom
EricYangTL wants to merge 2 commits intosteipete:mainfrom
Conversation
Extend --enable-commands to support dotted subcommand paths (e.g., gmail.search, gmail.drafts.create) in addition to top-level commands. Top-level entries like 'gmail' remain backward-compatible and allow all subcommands. Dotted entries restrict to specific subcommand paths. Examples: --enable-commands='gmail.search,gmail.drafts.create,calendar' --enable-commands='gmail.search,gmail.get,gmail.labels' Refs steipete#110 (related: per-service scope control for agent sandboxing)
Owner
|
Compared against #173 and #366, this looks like the cleaner runtime-policy path. It solves the concrete dotted subcommand allowlist gap in the existing |
This was referenced Mar 8, 2026
Owner
|
Thanks @EricYangTL! Landed dotted command-path allowlist support on main in d84148a, with shared matcher coverage and docs. Closing this PR as landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend --enable-commands to support dotted subcommand paths (e.g., gmail.search, gmail.drafts.create) in addition to top-level commands.
Top-level entries like 'gmail' remain backward-compatible and allow all subcommands. Dotted entries restrict to specific subcommand paths. My specific use case here is to enable gmail drafts but not sends, which is not available with top-level allowlist.
Examples:
--enable-commands='gmail.search,gmail.drafts.create,calendar'
--enable-commands='gmail.search,gmail.get,gmail.labels'
Refs #110 (related: per-service scope control for agent sandboxing)