[codex] Normalize legacy tweet URL entities#64
Merged
Conversation
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: [codex] Normalize legacy tweet URL entities This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
expandedUrlanddisplayUrlvalues on legacy stored URL entities at the shared rendering boundary.url/start/end-only rows.Why
Post-deploy production E2E found the all-time Bookmarks API returning 500 when a quoted tweet contained legacy URL metadata without expanded-link fields. The current API contract requires both fields, but old databases legitimately predate them.
Impact
Saved and quoted tweets now remain readable without rewriting the local database. Production-data proof changed Bookmarks from HTTP 500 to HTTP 200 in 333 ms.
Validation
pnpm exec vitest run src/lib/tweet-render.test.ts src/lib/queries.test.ts --reporter=verbose— 59 testspnpm checkpnpm build