Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UppyUploader: Add support for drag-n-dropping... #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bayprogrammer
Copy link
Member

@bayprogrammer bayprogrammer commented Nov 15, 2024

...a folder of files (rather than merely files themselves).

  • filament-uppy-component: Implement handleDrop() method, making use of Uppy's getDroppedFiles helper routine to correctly process dropped files which in fact folders filled with files.
  • UppyUploader: Utilize the new handleDrop() handler method of our component.

...a folder of files (rather than merely files themselves).

* `filament-uppy-component`: Implement `handleDrop()` method, making
  use of Uppy's `getDroppedFiles` helper routine to correctly process
  dropped files which in fact folders filled with files.

* `UppyUploader`: Utilize the new `handleDrop()` handler method of our
  component.
@bayprogrammer bayprogrammer self-assigned this Nov 15, 2024
@bayprogrammer bayprogrammer marked this pull request as ready for review November 15, 2024 18:15
@bayprogrammer bayprogrammer requested a review from dp88 November 22, 2024 19:05
@dp88
Copy link
Member

dp88 commented Nov 26, 2024

My only thought here is wondering if we want to also add some kind of parameter which would disallow dropping folders? I can't think of a reason at the moment, but if it's trivial to parameterize right now while the feature is brand new, perhaps we should.

@bayprogrammer
Copy link
Member Author

So I'm not entirely sure how or where that parameter would be passed, or what the alternative behavior would be if it were passed (the current behavior in master right now is to try to process the folder as a file being uploaded, which is non-sense behavior). So if we allowed disallowing folders, how would we detect that it was a folder that was dropped?

@dp88
Copy link
Member

dp88 commented Nov 26, 2024

That makes sense. Since this does only improve on current behavior, we can cross the bridge of disallowing folders altogether if the need arises later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants