Skip to content

ci: Validate PR title with commitlint and enforce trailing period. #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedseb merged 2 commits into from
Apr 10, 2026
Merged

ci: Validate PR title with commitlint and enforce trailing period. #366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc569ca
ci: Validate PR title with commitlint and enforce trailing period.
nedseb Apr 10, 2026
b2d9ed7
fix(ci): Pass PR title via env to avoid shell injection.
nedseb Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check-commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ jobs:

- name: "📜 Validate commit messages"
run: npx --no-install commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose

- name: "📜 Validate PR title (used as squash commit message)"
run: echo "${{ github.event.pull_request.title }}" | npx --no-install commitlint --verbose
Copy link
Copy Markdown
Contributor Author

@nedseb nedseb Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b2d9ed7: PR title is now passed via env: PR_TITLE and piped with printf '%s\n' instead of direct echo interpolation.

2 changes: 1 addition & 1 deletion commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
},
rules: {
'subject-case': [0],
'subject-full-stop': [0],
'subject-full-stop': [2, 'always', '.'],
'header-max-length': [2, 'always', 78],
'scope-enum': [
2,
Expand Down
Loading