Skip to content

Fix TypeScript errors in helmetData tests; run CI on push to all branches #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staylor merged 3 commits into from
Mar 3, 2026
+3 −6
Merged

Fix TypeScript errors in helmetData tests; run CI on push to all branches #265

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b32b7b3
Initial plan
Copilot Mar 3, 2026
6f272b6
fix: add non-null assertions in helmetData tests; run CI on all branches
Copilot Mar 3, 2026
4027486
ci: run only on push to avoid duplicate workflow runs
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ name: CI

on:
push:
branches: [main]
pull_request:
Copy link
Copy Markdown
Owner

@staylor staylor Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I think we can just run on push, getting duplicate runs

Copy link
Copy Markdown
Contributor Author

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4027486 — removed the pull_request trigger, keeping only push.

branches: [main]

jobs:
build:
Expand Down
6 changes: 3 additions & 3 deletions __tests__/server/helmetData.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('Helmet Data', () => {
<Helmet helmetData={helmetData} base={{ target: '_blank', href: 'http://localhost/' }} />
);

const head = helmetData.context.helmet;
const head = helmetData.context.helmet!;

expect(head.base).toBeDefined();
expect(head.base.toString).toBeDefined();
Expand All @@ -41,7 +41,7 @@ describe('Helmet Data', () => {
</Helmet>
);

const head = helmetData.context.helmet;
const head = helmetData.context.helmet!;

expect(head.base).toBeDefined();
expect(head.base.toString).toBeDefined();
Expand All @@ -62,7 +62,7 @@ describe('Helmet Data', () => {
</div>
);

const head = helmetData.context.helmet;
const head = helmetData.context.helmet!;

expect(head.base).toBeDefined();
expect(head.base.toString).toBeDefined();
Expand Down
Loading