-
Notifications
You must be signed in to change notification settings - Fork 265
feat: status go codex integraion arnaud #7046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
The new script allows running all the tests as well as selected tests
…u node for testing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7046 +/- ##
===========================================
- Coverage 59.77% 49.84% -9.94%
===========================================
Files 805 810 +5
Lines 114125 115648 +1523
===========================================
- Hits 68221 57646 -10575
- Misses 38918 52044 +13126
+ Partials 6986 5958 -1028
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| // Ideally use EnableCommunityHistoryArchiveProtocol | ||
| s.owner.archiveManager.SetCodexConfig(&ownercodexConfig) | ||
| err = s.owner.archiveManager.StartCodexClient() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without looking at the code, I thought Codex nodes were meant to be started automatically in SetOnline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about SetOnline because it is called when there is a connection change. But at least it should be called with EnableCommunityHistoryArchiveProtocol yes.
| // https://github.com/status-im/status-go/blob/6c82a6c2be7ebed93bcae3b9cf5053da3820de50/protocol/communities/manager.go#L4403 | ||
|
|
||
| // Ensure owner has archive | ||
| archiveIndex, err := s.owner.archiveManager.CodexLoadHistoryArchiveIndexFromFile(s.owner.identity, community.ID()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I had envisioned this test a bit differently. I was thinking that we'd create a getter/setter for messageArchiveInterval so that this value could be updated something very short for testing. This value will need to be settable for DST tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agree 100%. I just created a first version which is a copy of the torrent one to see if it works for Codex. I will look to improve this test.
d8d05ab to
5761ad4
Compare
Just a draft PR for tracking changes easily for Codex integration