refactor: use protected topics persistence interface #6962
+199
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6962 +/- ##
===========================================
+ Coverage 59.52% 59.83% +0.31%
===========================================
Files 810 809 -1
Lines 119476 119458 -18
===========================================
+ Hits 71121 71481 +360
+ Misses 41018 40611 -407
- Partials 7337 7366 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
force-pushed
the
refactor/waku-protected-topics-persistence
branch
from
ff630b7 to
9348690
Compare
osmaczko
force-pushed
the
refactor/waku-protected-topics-persistence
branch
from
9348690 to
476d6a2
Compare
igor-sirotin
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
I think this shouldn't be in persistence subpackage, but in waku package directly 🤔
To be used like waku.ProtectedTopic.
There was a problem hiding this comment.
Perhaps generate a stub with gomock?
There was a problem hiding this comment.
I don't think a mock has a proper use case here. I don't want to verify behavior, but rather provide functional persistence for tests. It isn't a stub either. I'll rename it to persistence_in_memory.go.
There was a problem hiding this comment.
@osmaczko indeed. Don't bother, it's not that important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterates: #6792