chore: stop vendoring #6951
Draft
chore: stop vendoring #6951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/bump-waku-go-bindings #6951 +/- ##
==============================================================
- Coverage 59.46% 59.40% -0.06%
==============================================================
Files 810 810
Lines 119476 119476
==============================================================
- Hits 71047 70979 -68
- Misses 41083 41131 +48
- Partials 7346 7366 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Sep 25, 2025
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
bcc7833 to
485d724
Compare
|
@status-im/devops guys can you please assist me with |
igor-sirotin
force-pushed
the
chore/nwaku-submodule
branch
from
06d4055 to
3564b77
Compare
igor-sirotin
changed the base branch from
chore/nwaku-submodule
to
feat/bump-waku-go-bindings
ci: run lint on all base branch prs ci: reorder steps
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
dde9a6b to
c61255e
Compare
Signed-off-by: Jakub Sokołowski <[email protected]>
|
Thank you for opening this pull request! We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted. Details:
|
|
The trick is actually that # The SRI hash of the vendored dependencies.
# If `vendorHash` is `null`, no dependencies are fetched and
# the build relies on the vendor folder within the source.
vendorHash ? throw (
if args ? vendorSha256 then
"buildGoModule: Expect vendorHash instead of vendorSha256"
else
"buildGoModule: vendorHash is missing"
),So from now on we need to specify a real hash. Which means it will have to be updated every time dependencies change. |
Thanks for fixing this.
@jakubgs is there any chance we can avoid this? It's gonna be quite an annoying procedure 😄 |
|
I know of no built-in way of doing this. The purpose of We'd have to write some kind of script to generate the hash for us, but it would have to be committed anyway by the devs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Blocked until resolved:
Description
Stop vendoring Go dependencies. Delete
vendor/directory.Reasoning
As for today, vendoring dependencies in Go is more of a burden than real need.
Major Go projects like
go-ethereumdon't vendor.The only reason for vendoring is to have all dependencies on hands in case one of them is suddenly becomes unavailable
(deleted of removed from public). On the other hand, it makes the repo heavier and PRs less clear, which we believe is more important. This becomes more obvious with the usage of
go tool(e.g. in PRs like #6933).nwakuCurrently approach with cloning
nwakurepository doesn't work without vendoring, as it requiressudorights.This PR is currently based on a branch wherenwakuis a submodule, but I am looking into better solutions right now.Currently the PR uses a
libwakuincluded in thewaku-go-bindingsrepo: waku-org/waku-go-bindings#92