Skip to content

Conversation

siddarthkay
Copy link
Contributor

Summary

Desktop PR jobs will now skip Intel MacOS hosts due to the change in label logic.
Intel MacOS hosts are only required for Nimbus builds, we could skip building status-go on that host.

@siddarthkay siddarthkay self-assigned this Sep 1, 2025
@siddarthkay siddarthkay requested a review from a team as a code owner September 1, 2025 12:49
@status-im-auto
Copy link
Member

status-im-auto commented Sep 1, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
4b0bbde #1 2025-09-01 12:51:25 ~1 min android 📄log
✔️ 4b0bbde #1 2025-09-01 12:52:54 ~2 min linux/status-go 📦zip
✔️ 4b0bbde #1 2025-09-01 12:53:28 ~3 min macos/status-go 📦zip
4b0bbde #1 2025-09-01 12:54:16 ~4 min ios 📄log
✔️ 4b0bbde #1 2025-09-01 12:56:26 ~6 min windows/status-go 📦zip
✔️ 4b0bbde #1 2025-09-01 12:58:08 ~7 min tests-rpc 📄log
✔️ 4b0bbde #1 2025-09-01 12:59:43 ~9 min linux/nwaku 📦zip
✔️ 4b0bbde #1 2025-09-01 13:14:26 ~24 min tests 📄log
✔️ 9dc5214 #2 2025-09-01 13:25:45 ~2 min linux/status-go 📦zip
✔️ 9dc5214 #2 2025-09-01 13:26:17 ~3 min macos/status-go 📦zip
✔️ 9dc5214 #2 2025-09-01 13:29:23 ~6 min windows/status-go 📦zip
✔️ 9dc5214 #2 2025-09-01 13:31:07 ~7 min tests-rpc 📄log
✔️ 9dc5214 #2 2025-09-01 13:33:02 ~9 min linux/nwaku 📦zip
✔️ 9dc5214 #2 2025-09-01 13:46:41 ~23 min tests 📄log

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.21%. Comparing base (4d5a7cd) to head (9dc5214).
⚠️ Report is 79 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6887      +/-   ##
===========================================
- Coverage    59.23%   59.21%   -0.03%     
===========================================
  Files          829      829              
  Lines       122287   122287              
===========================================
- Hits         72442    72409      -33     
- Misses       42341    42384      +43     
+ Partials      7504     7494      -10     
Flag Coverage Δ
functional 31.49% <ø> (+0.03%) ⬆️
unit 55.37% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 46 files with indirect coverage changes

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the getAgentLabelFromJob() library function.

@siddarthkay siddarthkay force-pushed the skip-intel-macos-hosts branch from 4b0bbde to 9dc5214 Compare September 1, 2025 13:22
@siddarthkay siddarthkay requested a review from jakubgs September 1, 2025 14:03
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the title and description of the commit and PR.

@siddarthkay siddarthkay closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants