chore_: running CI with nwaku #6768
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (61)
|
gabrielmer
commented
Jul 24, 2025
| LIBWAKU := $(CURDIR)/vendor/github.com/waku-org/waku-go-bindings/third_party/nwaku/build/libwaku.$(LIBWAKU_EXT) | ||
| $(LIBWAKU): | ||
| ifeq ($(USE_NWAKU),true) | ||
| ifeq (true,true) |
There was a problem hiding this comment.
this will be reverted once we want to merge the PR
once we start using nwaku as a default we will need to remove the if condition
There was a problem hiding this comment.
@Ivansete-status : you can start here, this flag is available in CI
status-go/_assets/ci/Jenkinsfile.nwaku
Line 96 in 790ef72
gabrielmer
commented
Jul 24, 2025
| var err error | ||
| s.messagingEnv, err = messaging.NewTestMessagingEnvironment() | ||
| s.Require().NoError(err) | ||
| s.Require().NoError(s.messagingEnv.Setup()) |
There was a problem hiding this comment.
removing this because it just started the node, and the node gets already started in NewTestMessagingEnvironment
starting the node twice was giving issues. nwaku has to protect agains it but in any case, it's a bug to attempt to do it
gabrielmer
commented
Jul 24, 2025
| @@ -1,5 +1,5 @@ | |||
| //go:build !use_nwaku | |||
There was a problem hiding this comment.
in order to run the CI and test, I changed the default to be nwaku instead of go-waku. That's the changes in the tags in most of the files in this PR.
Once the PR is ready to merge, we should rever this changes in keep go-waku as the default. Probably add a CI job running everything for nwaku
gabrielmer
commented
Jul 24, 2025
There was a problem hiding this comment.
Nwaku functionalities are tested in waku-go-bindings. We should check if there's anything covered in the go-waku test without the equivalent being covered in waku-go-bindings's tests and add it to this file. The redundant tests shouldn't be here
gabrielmer
force-pushed
the
chore-nwaku-tests
branch
from
7648f03 to
f91e5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to test running the CI with nwaku. Once it passes it will be cleaned up