ci_: get rid of dirty flag #6677
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
jakubgs
approved these changes
Jun 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6677 +/- ##
===========================================
+ Coverage 60.47% 60.56% +0.09%
===========================================
Files 828 828
Lines 103720 103720
===========================================
+ Hits 62727 62821 +94
+ Misses 33389 33318 -71
+ Partials 7604 7581 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@siddarthkay do we still want this merged? Or should we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found few instances of
--dirtyin status-go as well,Now that we don't have this versioning in status-desktop it would be consistent if we removed it from here as well.