Skip to content

test_: minor fix of undefined temp_dir#6537

Merged
igor-sirotin merged 1 commit intodevelopfrom
test/temp_dir_none
Apr 22, 2025
Merged

test_: minor fix of undefined temp_dir#6537
igor-sirotin merged 1 commit intodevelopfrom
test/temp_dir_none

Conversation

@igor-sirotin
Copy link
Copy Markdown
Collaborator

Prevents accessing an undefined temp_dir property in __del__

@igor-sirotin igor-sirotin self-assigned this Apr 16, 2025
@status-im-auto
Copy link
Copy Markdown
Member

status-im-auto commented Apr 16, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 18213ed #1 2025-04-16 15:39:44 ~2 min android 📦aar
✔️ 18213ed #1 2025-04-16 15:39:57 ~3 min ios 📦zip
✔️ 18213ed #1 2025-04-16 15:40:21 ~3 min macos 📦zip
✔️ 18213ed #1 2025-04-16 15:41:24 ~4 min windows 📦zip
✔️ 18213ed #1 2025-04-16 15:41:58 ~5 min macos 📦zip
✔️ 18213ed #1 2025-04-16 15:42:07 ~5 min linux 📦zip
✔️ 18213ed #1 2025-04-16 15:45:08 ~8 min tests-rpc 📄log
✔️ 18213ed #1 2025-04-16 16:12:16 ~35 min tests 📄log

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.31%. Comparing base (4f33989) to head (18213ed).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6537      +/-   ##
===========================================
- Coverage    60.45%   60.31%   -0.14%     
===========================================
  Files          833      830       -3     
  Lines       104003   103573     -430     
===========================================
- Hits         62870    62472     -398     
+ Misses       33603    33569      -34     
- Partials      7530     7532       +2     
Flag Coverage Δ
functional 25.58% <ø> (-0.03%) ⬇️
unit 58.14% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit 8ba28aa into develop Apr 22, 2025
19 checks passed
@igor-sirotin igor-sirotin deleted the test/temp_dir_none branch April 22, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants