test_: message reactions test #6335

yevh-berdnyk · 2025-02-07T10:56:43Z

status-im-auto · 2025-02-07T11:00:44Z

Jenkins Builds

Click to see older builds (31)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ef26d60`	#1	2025-02-07 11:00:44	~3 min	`macos`	📦`zip`
✔️	`ef26d60`	#1	2025-02-07 11:02:09	~5 min	`ios`	📦`zip`
✔️	`ef26d60`	#1	2025-02-07 11:02:18	~5 min	`macos`	📦`zip`
✖️	`ef26d60`	#1	2025-02-07 11:02:29	~5 min	`tests-rpc`	📄`log`
✔️	`ef26d60`	#1	2025-02-07 11:02:52	~5 min	`linux`	📦`zip`
✔️	`ef26d60`	#1	2025-02-07 11:02:53	~5 min	`android`	📦`aar`
✔️	`ef26d60`	#1	2025-02-07 11:03:53	~6 min	`windows`	📦`zip`
✔️	`ef26d60`	#1	2025-02-07 11:32:15	~35 min	`tests`	📄`log`

✔️	`d75507f`	#2	2025-02-07 13:46:10	~3 min	`macos`	📦`zip`
✔️	`d75507f`	#2	2025-02-07 13:46:23	~3 min	`ios`	📦`zip`
✔️	`d75507f`	#2	2025-02-07 13:46:25	~3 min	`windows`	📦`zip`
✔️	`d75507f`	#2	2025-02-07 13:47:38	~5 min	`macos`	📦`zip`
✖️	`d75507f`	#2	2025-02-07 13:47:48	~5 min	`tests-rpc`	📄`log`
✔️	`d75507f`	#2	2025-02-07 13:48:01	~5 min	`linux`	📦`zip`
✔️	`d75507f`	#2	2025-02-07 13:48:11	~5 min	`android`	📦`aar`
✔️	`d75507f`	#2	2025-02-07 14:13:27	~30 min	`tests`	📄`log`

✔️	`eab259f`	#3	2025-02-07 13:49:58	~3 min	`macos`	📦`zip`
✔️	`eab259f`	#3	2025-02-07 13:50:18	~3 min	`windows`	📦`zip`
✔️	`eab259f`	#3	2025-02-07 13:50:25	~3 min	`ios`	📦`zip`
✔️	`eab259f`	#3	2025-02-07 13:52:51	~5 min	`macos`	📦`zip`
✖️	`eab259f`	#3	2025-02-07 13:53:01	~4 min	`tests-rpc`	📄`log`
✔️	`eab259f`	#3	2025-02-07 13:53:39	~5 min	`linux`	📦`zip`
✔️	`eab259f`	#3	2025-02-07 13:54:01	~5 min	`android`	📦`aar`

✔️	`24ee0b6`	#4	2025-02-07 13:59:15	~3 min	`macos`	📦`zip`
✔️	`24ee0b6`	#4	2025-02-07 14:00:11	~4 min	`windows`	📦`zip`
✔️	`24ee0b6`	#4	2025-02-07 14:00:34	~4 min	`ios`	📦`zip`
✖️	`24ee0b6`	#4	2025-02-07 14:00:41	~5 min	`tests-rpc`	📄`log`
✔️	`24ee0b6`	#4	2025-02-07 14:00:45	~5 min	`macos`	📦`zip`
✔️	`24ee0b6`	#4	2025-02-07 14:01:16	~5 min	`linux`	📦`zip`
✔️	`24ee0b6`	#4	2025-02-07 14:01:22	~5 min	`android`	📦`aar`
✔️	`24ee0b6`	#3	2025-02-07 14:44:29	~30 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ae0542d`	#5	2025-02-11 14:56:58	~3 min	`macos`	📦`zip`
✔️	`ae0542d`	#5	2025-02-11 14:57:23	~3 min	`windows`	📦`zip`
✔️	`ae0542d`	#5	2025-02-11 14:58:42	~5 min	`linux`	📦`zip`
✔️	`ae0542d`	#5	2025-02-11 14:58:51	~5 min	`macos`	📦`zip`
✔️	`ae0542d`	#5	2025-02-11 14:58:52	~5 min	`ios`	📦`zip`
✔️	`ae0542d`	#5	2025-02-11 14:59:03	~5 min	`android`	📦`aar`
✖️	`ae0542d`	#5	2025-02-11 15:01:58	~8 min	`tests-rpc`	📄`log`
✖️	`ae0542d`	#4	2025-02-11 15:26:22	~32 min	`tests`	📄`log`

✔️	`e68a3b4`	#6	2025-02-11 15:00:40	~3 min	`macos`	📦`zip`
✔️	`e68a3b4`	#6	2025-02-11 15:01:23	~3 min	`windows`	📦`zip`
✔️	`e68a3b4`	#6	2025-02-11 15:04:17	~5 min	`ios`	📦`zip`
✔️	`e68a3b4`	#6	2025-02-11 15:04:20	~5 min	`macos`	📦`zip`
✔️	`e68a3b4`	#6	2025-02-11 15:04:49	~6 min	`linux`	📦`zip`
✔️	`e68a3b4`	#6	2025-02-11 15:06:48	~7 min	`android`	📦`aar`
✔️	`e68a3b4`	#6	2025-02-11 15:19:31	~17 min	`tests-rpc`	📄`log`
✔️	`e68a3b4`	#5	2025-02-11 16:01:15	~34 min	`tests`	📄`log`

codecov · 2025-02-07T11:32:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.36%. Comparing base (cd1c084) to head (e68a3b4).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6335      +/-   ##
===========================================
- Coverage    60.41%   60.36%   -0.06%     
===========================================
  Files          845      845              
  Lines       111357   111357              
===========================================
- Hits         67280    67221      -59     
- Misses       36268    36309      +41     
- Partials      7809     7827      +18

Flag	Coverage Δ
functional	`0.45% <ø> (ø)`
unit	`60.38% <ø> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

fbarbu15

Thanks! left some minor comments
Also I saw that the linting job failed
Can you please run black on the new file and also install the git pre-commit hooks (pre-commit install) so in the future this formatting is done automatically? Thank you

tests-functional/tests/test_wakuext_message_reactions.py

yevh-berdnyk · 2025-02-07T13:58:10Z

Thanks! left some minor comments Also I saw that the linting job failed Can you please run black on the new file and also install the git pre-commit hooks (pre-commit install) so in the future this formatting is done automatically? Thank you

Thanks for the advice with pre-commit, it works now! :)

fbarbu15 · 2025-02-07T14:41:59Z

Thanks! left some minor comments Also I saw that the linting job failed Can you please run black on the new file and also install the git pre-commit hooks (pre-commit install) so in the future this formatting is done automatically? Thank you

Thanks for the advice with pre-commit, it works now! :)

Btw your tests are failing in jenkins because of this privileged flag that the containers are trying to use. Here's how @antdanchenko approached this
https://github.com/status-im/status-go/pull/6321/files#diff-21147cf06fda10e3d5345448e37a009673edb3b32b3eb03a366b729f33d6044aR30

maybe we need a dedicated fixture setup_two_unprivileged_nodes

yevh-berdnyk · 2025-02-07T14:46:14Z

Thanks! left some minor comments Also I saw that the linting job failed Can you please run black on the new file and also install the git pre-commit hooks (pre-commit install) so in the future this formatting is done automatically? Thank you

Thanks for the advice with pre-commit, it works now! :)

Btw your tests are failing in jenkins because of this privileged flag that the containers are trying to use. Here's how @antdanchenko approached this https://github.com/status-im/status-go/pull/6321/files#diff-21147cf06fda10e3d5345448e37a009673edb3b32b3eb03a366b729f33d6044aR30

maybe we need a dedicated fixture setup_two_unprivileged_nodes

Yep, we decided that I'll wait for his PR to be merged before merging or updating this one in terms of this issue

yevh-berdnyk self-assigned this Feb 7, 2025

yevh-berdnyk requested review from igor-sirotin, churik, antdanchenko and fbarbu15 February 7, 2025 10:56

fbarbu15 requested changes Feb 7, 2025

View reviewed changes

tests-functional/tests/test_wakuext_message_reactions.py Outdated Show resolved Hide resolved

tests-functional/tests/test_wakuext_message_reactions.py Show resolved Hide resolved

tests-functional/tests/test_wakuext_message_reactions.py Show resolved Hide resolved

yevh-berdnyk force-pushed the test-message-reactions branch 2 times, most recently from eab259f to 24ee0b6 Compare February 7, 2025 13:55

fbarbu15 approved these changes Feb 7, 2025

View reviewed changes

tests-functional/tests/test_wakuext_message_reactions.py Show resolved Hide resolved

tests-functional/tests/test_wakuext_message_reactions.py Outdated Show resolved Hide resolved

antdanchenko approved these changes Feb 11, 2025

View reviewed changes

yevh-berdnyk added 2 commits February 11, 2025 16:45

test_: message reactions test

e6d8518

test_: linting

c675b80

yevh-berdnyk force-pushed the test-message-reactions branch from 24ee0b6 to ae0542d Compare February 11, 2025 14:53

test_: privileged/unprivileged notes

e68a3b4

yevh-berdnyk force-pushed the test-message-reactions branch from ae0542d to e68a3b4 Compare February 11, 2025 14:54

yevh-berdnyk merged commit 735b574 into develop Feb 11, 2025
19 checks passed

yevh-berdnyk deleted the test-message-reactions branch February 11, 2025 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_: message reactions test #6335

test_: message reactions test #6335

yevh-berdnyk commented Feb 7, 2025

status-im-auto commented Feb 7, 2025 •

edited

Loading

codecov bot commented Feb 7, 2025 •

edited

Loading

fbarbu15 left a comment

yevh-berdnyk commented Feb 7, 2025

fbarbu15 commented Feb 7, 2025

yevh-berdnyk commented Feb 7, 2025

test_: message reactions test #6335

test_: message reactions test #6335

Conversation

yevh-berdnyk commented Feb 7, 2025

status-im-auto commented Feb 7, 2025 • edited Loading

Jenkins Builds

codecov bot commented Feb 7, 2025 • edited Loading

Codecov Report

fbarbu15 left a comment

Choose a reason for hiding this comment

yevh-berdnyk commented Feb 7, 2025

fbarbu15 commented Feb 7, 2025

yevh-berdnyk commented Feb 7, 2025

status-im-auto commented Feb 7, 2025 •

edited

Loading

codecov bot commented Feb 7, 2025 •

edited

Loading