Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: remove go-ethereum's UnmarshalPubkey usage #6331

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

osmaczko
Copy link
Contributor

@osmaczko osmaczko commented Feb 6, 2025

relates: #6330

@osmaczko osmaczko changed the title Fix/CVE 2025 24883 fix_: prevent CVE-2025-24883 in eth-node's crypto package Feb 6, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 6, 2025

Jenkins Builds

Click to see older builds (16)
Commit #️⃣ Finished (UTC) Duration Platform Result
75f398f #1 2025-02-06 08:16:13 ~1 min ios 📄log
75f398f #1 2025-02-06 08:16:40 ~2 min android 📄log
75f398f #1 2025-02-06 08:16:49 ~2 min macos 📄log
75f398f #1 2025-02-06 08:17:29 ~2 min linux 📄log
75f398f #1 2025-02-06 08:17:54 ~3 min windows 📄log
✖️ 75f398f #1 2025-02-06 08:17:54 ~3 min tests-rpc 📄log
✖️ 75f398f #1 2025-02-06 08:17:57 ~3 min tests 📄log
75f398f #1 2025-02-06 08:18:29 ~3 min macos 📄log
5958cf3 #2 2025-02-06 08:17:44 ~1 min ios 📄log
5958cf3 #2 2025-02-06 08:18:46 ~2 min android 📄log
5958cf3 #2 2025-02-06 08:18:56 ~2 min macos 📄log
5958cf3 #2 2025-02-06 08:19:33 ~1 min windows 📄log
✖️ 5958cf3 #2 2025-02-06 08:20:04 ~2 min tests 📄log
5958cf3 #2 2025-02-06 08:20:13 ~2 min linux 📄log
✖️ 5958cf3 #2 2025-02-06 08:20:34 ~2 min tests-rpc 📄log
5958cf3 #2 2025-02-06 08:22:23 ~3 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e803219 #3 2025-02-06 08:37:17 ~3 min windows 📦zip
✔️ e803219 #3 2025-02-06 08:38:02 ~3 min macos 📦zip
✔️ e803219 #3 2025-02-06 08:38:13 ~4 min ios 📦zip
✔️ e803219 #3 2025-02-06 08:38:54 ~4 min tests-rpc 📄log
✔️ e803219 #3 2025-02-06 08:39:36 ~5 min linux 📦zip
✔️ e803219 #3 2025-02-06 08:39:56 ~5 min macos 📦zip
✔️ e803219 #3 2025-02-06 08:40:13 ~6 min android 📦aar
✔️ e803219 #3 2025-02-06 09:04:03 ~29 min tests 📄log
✔️ 46ecf1e #4 2025-02-07 11:31:42 ~3 min windows 📦zip
✔️ 46ecf1e #4 2025-02-07 11:32:09 ~3 min ios 📦zip
✔️ 46ecf1e #4 2025-02-07 11:32:25 ~3 min macos 📦zip
✔️ 46ecf1e #4 2025-02-07 11:33:15 ~4 min tests-rpc 📄log
✔️ 46ecf1e #4 2025-02-07 11:33:25 ~5 min linux 📦zip
✔️ 46ecf1e #4 2025-02-07 11:34:06 ~5 min macos 📦zip
✔️ 46ecf1e #4 2025-02-07 11:34:59 ~6 min android 📦aar
✔️ 46ecf1e #4 2025-02-07 12:00:10 ~31 min tests 📄log

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (0526d18) to head (46ecf1e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
wakuv1/api.go 0.00% 1 Missing ⚠️
wakuv2/api.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6331   +/-   ##
========================================
  Coverage    60.35%   60.36%           
========================================
  Files          845      845           
  Lines       111357   111357           
========================================
+ Hits         67211    67217    +6     
  Misses       36310    36310           
+ Partials      7836     7830    -6     
Flag Coverage Δ
functional 0.45% <0.00%> (ø)
unit 60.37% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appdatabase/database.go 70.54% <ø> (ø)
wakuv2/persistence/signed_messages.go 60.00% <ø> (ø)
wakuv1/api.go 36.29% <0.00%> (ø)
wakuv2/api.go 38.26% <0.00%> (ø)

... and 34 files with indirect coverage changes

@osmaczko osmaczko changed the title fix_: prevent CVE-2025-24883 in eth-node's crypto package fix_: remove go-ethereum's UnmarshalPubkey usage Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants