-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_: bring back messaging tests for functional check, added light client messaging #6321
Conversation
Jenkins BuildsClick to see older builds (55)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6321 +/- ##
========================================
Coverage 60.32% 60.33%
========================================
Files 845 845
Lines 111357 111357
========================================
+ Hits 67180 67186 +6
- Misses 36347 36355 +8
+ Partials 7830 7816 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Left a few minor comments/questions
15625f3
to
5774be6
Compare
added functional messaging tests in default and Lightclient modes