Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_: bring back messaging tests for functional check, added light client messaging #6321

Merged
merged 9 commits into from
Feb 11, 2025

Conversation

antdanchenko
Copy link
Contributor

@antdanchenko antdanchenko commented Feb 3, 2025

added functional messaging tests in default and Lightclient modes

@status-im-auto
Copy link
Member

status-im-auto commented Feb 3, 2025

Jenkins Builds

Click to see older builds (55)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 9d629fe #1 2025-02-03 14:06:24 ~4 min tests-rpc 📄log
✔️ 9d629fe #1 2025-02-03 14:06:48 ~5 min macos 📦zip
✔️ 9d629fe #1 2025-02-03 14:07:01 ~5 min macos 📦zip
✔️ 9d629fe #1 2025-02-03 14:07:13 ~5 min windows 📦zip
✔️ 9d629fe #1 2025-02-03 14:07:21 ~5 min ios 📦zip
✔️ 9d629fe #1 2025-02-03 14:07:21 ~5 min linux 📦zip
✔️ 9d629fe #1 2025-02-03 14:08:14 ~6 min android 📦aar
✔️ 9d629fe #1 2025-02-03 14:32:15 ~30 min tests 📄log
✔️ edf6545 #2 2025-02-03 15:27:52 ~4 min macos 📦zip
✔️ edf6545 #2 2025-02-03 15:28:14 ~4 min ios 📦zip
✔️ edf6545 #2 2025-02-03 15:28:38 ~5 min macos 📦zip
✔️ edf6545 #2 2025-02-03 15:29:04 ~5 min android 📦aar
✔️ edf6545 #2 2025-02-03 15:29:05 ~5 min windows 📦zip
✔️ edf6545 #2 2025-02-03 15:29:17 ~5 min linux 📦zip
✖️ edf6545 #2 2025-02-03 15:32:43 ~9 min tests-rpc 📄log
✔️ edf6545 #2 2025-02-03 15:55:18 ~31 min tests 📄log
✔️ 336948a #3 2025-02-03 15:33:25 ~3 min windows 📦zip
✔️ 336948a #3 2025-02-03 15:33:47 ~4 min macos 📦zip
✔️ 336948a #3 2025-02-03 15:33:57 ~4 min ios 📦zip
✔️ 336948a #3 2025-02-03 15:34:36 ~5 min macos 📦zip
✔️ 336948a #3 2025-02-03 15:35:51 ~6 min android 📦aar
✔️ 336948a #3 2025-02-03 15:36:01 ~6 min linux 📦zip
✖️ 336948a #3 2025-02-03 15:41:34 ~8 min tests-rpc 📄log
✔️ e31a4f6 #4 2025-02-03 15:52:22 ~4 min windows 📦zip
✔️ e31a4f6 #4 2025-02-03 15:52:34 ~4 min macos 📦zip
✔️ e31a4f6 #4 2025-02-03 15:52:53 ~4 min ios 📦zip
✔️ e31a4f6 #4 2025-02-03 15:53:21 ~5 min linux 📦zip
✔️ e31a4f6 #4 2025-02-03 15:53:22 ~5 min macos 📦zip
✔️ e31a4f6 #4 2025-02-03 15:55:32 ~7 min android 📦aar
✔️ e31a4f6 #4 2025-02-03 15:57:27 ~9 min tests-rpc 📄log
✔️ e31a4f6 #3 2025-02-03 16:24:53 ~29 min tests 📄log
✔️ f8dbb02 #5 2025-02-06 14:25:03 ~3 min macos 📦zip
✔️ f8dbb02 #5 2025-02-06 14:25:14 ~3 min windows 📦zip
✔️ f8dbb02 #5 2025-02-06 14:25:25 ~4 min ios 📦zip
✔️ f8dbb02 #5 2025-02-06 14:26:19 ~5 min macos 📦zip
✔️ f8dbb02 #5 2025-02-06 14:26:45 ~5 min linux 📦zip
✔️ f8dbb02 #5 2025-02-06 14:27:19 ~6 min android 📦aar
✖️ f8dbb02 #5 2025-02-06 14:30:27 ~9 min tests-rpc 📄log
✔️ f8dbb02 #4 2025-02-06 14:52:36 ~31 min tests 📄log
✔️ 15625f3 #6 2025-02-10 11:54:30 ~4 min macos 📦zip
✔️ 15625f3 #6 2025-02-10 11:55:31 ~5 min macos 📦zip
✔️ 15625f3 #6 2025-02-10 11:55:44 ~5 min windows 📦zip
✔️ 15625f3 #6 2025-02-10 11:55:50 ~5 min linux 📦zip
✔️ 15625f3 #6 2025-02-10 11:56:39 ~6 min android 📦aar
✖️ 15625f3 #6 2025-02-10 12:01:41 ~11 min tests-rpc 📄log
✔️ 15625f3 #5 2025-02-10 12:21:21 ~30 min tests 📄log
✔️ 15625f3 #6 2025-02-10 18:41:41 ~6 hr 51 min ios 📦zip
✔️ 5774be6 #7 2025-02-11 12:18:51 ~4 min windows 📦zip
✔️ 5774be6 #7 2025-02-11 12:19:15 ~4 min macos 📦zip
✔️ 5774be6 #7 2025-02-11 12:19:26 ~5 min ios 📦zip
✔️ 5774be6 #7 2025-02-11 12:19:33 ~5 min macos 📦zip
✔️ 5774be6 #7 2025-02-11 12:19:46 ~5 min linux 📦zip
✔️ 5774be6 #7 2025-02-11 12:20:32 ~6 min android 📦aar
✖️ 5774be6 #7 2025-02-11 12:25:35 ~11 min tests-rpc 📄log
✔️ 5774be6 #6 2025-02-11 12:45:12 ~30 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7830c15 #8 2025-02-11 12:39:27 ~4 min windows 📦zip
✔️ 7830c15 #8 2025-02-11 12:39:44 ~4 min macos 📦zip
✔️ 7830c15 #8 2025-02-11 12:40:17 ~5 min ios 📦zip
✔️ 7830c15 #8 2025-02-11 12:40:28 ~5 min macos 📦zip
✔️ 7830c15 #8 2025-02-11 12:41:07 ~5 min linux 📦zip
✔️ 7830c15 #8 2025-02-11 12:41:49 ~6 min android 📦aar
✔️ 7830c15 #8 2025-02-11 12:42:57 ~7 min tests-rpc 📄log
✔️ 073ad53 #9 2025-02-11 12:46:37 ~3 min windows 📦zip
✔️ 073ad53 #9 2025-02-11 12:47:13 ~4 min macos 📦zip
✔️ 073ad53 #9 2025-02-11 12:47:44 ~4 min ios 📦zip
✔️ 073ad53 #9 2025-02-11 12:48:07 ~5 min macos 📦zip
✔️ 073ad53 #9 2025-02-11 12:49:11 ~6 min android 📦aar
✔️ 073ad53 #9 2025-02-11 12:50:25 ~7 min linux 📦zip
✔️ 073ad53 #9 2025-02-11 12:52:45 ~9 min tests-rpc 📄log
✔️ 073ad53 #7 2025-02-11 13:14:24 ~29 min tests 📄log

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (c099460) to head (073ad53).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6321   +/-   ##
========================================
  Coverage    60.32%   60.33%           
========================================
  Files          845      845           
  Lines       111357   111357           
========================================
+ Hits         67180    67186    +6     
- Misses       36347    36355    +8     
+ Partials      7830     7816   -14     
Flag Coverage Δ
functional 0.45% <ø> (ø)
unit 60.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@antdanchenko antdanchenko changed the title test_: bring back messaging tests for functional check test_: bring back messaging tests for functional check, added light client messaging Feb 3, 2025
@antdanchenko antdanchenko marked this pull request as ready for review February 3, 2025 15:30
Copy link
Contributor

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Left a few minor comments/questions

tests-functional/tests/test_waku_rpc.py Outdated Show resolved Hide resolved
tests-functional/tests/test_cases.py Outdated Show resolved Hide resolved
tests-functional/tests/test_waku_rpc.py Show resolved Hide resolved
@antdanchenko antdanchenko force-pushed the test-functional-messaging branch from 15625f3 to 5774be6 Compare February 11, 2025 12:14
@antdanchenko antdanchenko merged commit cd1c084 into develop Feb 11, 2025
18 of 19 checks passed
@antdanchenko antdanchenko deleted the test-functional-messaging branch February 11, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants