Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_: set github codeowners for github workflows #6290

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Jan 28, 2025

closes #6313

@igor-sirotin igor-sirotin requested review from fbarbu15 and a team January 28, 2025 11:35
@igor-sirotin igor-sirotin self-assigned this Jan 28, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 28, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c2fbd5a #1 2025-01-28 11:39:35 ~3 min ios 📦zip
✔️ c2fbd5a #1 2025-01-28 11:40:04 ~4 min macos 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:27 ~5 min linux 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:33 ~5 min macos 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:35 ~5 min windows 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:44 ~5 min android 📦aar
✔️ c2fbd5a #1 2025-01-28 11:42:43 ~6 min tests-rpc 📄log
✔️ c2fbd5a #1 2025-01-28 12:07:34 ~31 min tests 📄log
✔️ 4fa38b7 #2 2025-02-05 12:16:50 ~4 min macos 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:19:04 ~7 min macos 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:19:43 ~7 min ios 📦zip
✖️ 4fa38b7 #2 2025-02-05 12:23:22 ~11 min tests-rpc 📄log
✔️ 4fa38b7 #2 2025-02-05 12:25:50 ~14 min android 📦aar
✔️ 4fa38b7 #2 2025-02-05 12:26:11 ~14 min linux 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:52:40 ~40 min tests 📄log
✔️ 4fa38b7 #3 2025-02-12 07:50:32 ~5 min windows 📦zip
✔️ 4fa38b7 #3 2025-02-12 08:18:01 ~6 min tests-rpc 📄log

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.87%. Comparing base (06d2419) to head (4fa38b7).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6290      +/-   ##
===========================================
+ Coverage    61.84%   61.87%   +0.03%     
===========================================
  Files          843      843              
  Lines       111287   111287              
===========================================
+ Hits         68823    68859      +36     
+ Misses       34497    34479      -18     
+ Partials      7967     7949      -18     
Flag Coverage Δ
functional 21.65% <ø> (+0.02%) ⬆️
unit 60.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@iurimatias iurimatias added this to the 2.33.0 Beta milestone Jan 30, 2025
@iurimatias iurimatias removed this from the 2.33.0 Beta milestone Jan 31, 2025
@yakimant
Copy link
Member

yakimant commented Feb 3, 2025

Can we add security team? FYI @0xM3R

@igor-sirotin
Copy link
Collaborator Author

Can we add security team? FYI @0xM3R

We can if @0xM3R finds it's necessary

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need security to review those.

@igor-sirotin igor-sirotin requested review from jakubgs and 0xM3R February 5, 2025 12:11
@igor-sirotin igor-sirotin requested a review from jakubgs February 6, 2025 19:36
Copy link

@0xM3R 0xM3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-sirotin igor-sirotin merged commit 45adccd into develop Feb 12, 2025
19 checks passed
@igor-sirotin igor-sirotin deleted the ci/github-workflows-codeowners branch February 12, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set github codeowners for github workflows
7 participants