feat_: add pre login log #6285
Open
feat_: add pre login log #6285
+60
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
qfrank
force-pushed
the
feat/pre_login_log
branch
2 times, most recently
from
61298b1 to
ce0993d
Compare
qfrank
force-pushed
the
feat/pre_login_log
branch
from
ce0993d to
3d90b00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6285 +/- ##
===========================================
- Coverage 61.84% 61.82% -0.02%
===========================================
Files 843 843
Lines 111287 111308 +21
===========================================
- Hits 68823 68816 -7
- Misses 34497 34517 +20
- Partials 7967 7975 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Jan 28, 2025
ilmotta
reviewed
Jan 28, 2025
There was a problem hiding this comment.
@qfrank, code LGTM. I'm just missing some evidence that the default ERROR level during pre-login is not leaking any private information. Could you please verify the log Error calls are not leaking private data? If you share with me the list of Error call sites during pre login I can also double-check (as a reviewer).
| @@ -2584,6 +2587,14 @@ func (b *GethStatusBackend) Logout() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (b *GethStatusBackend) switchToPreLoginLog() error { | |||
There was a problem hiding this comment.
I think it's beneficial to add a comment somewhere (could be here as a function documentation) explaining why this pre-login approach exists, otherwise the rationale will be a scattered and difficult to find in GH discussions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary:
SetupLogSettingsto the end of the call chain (e.g.createAccountAndLogin/loginAccount/restoreAccountAndLogin) to ensure that logs before a successful login are written to pre_login.logrelated: status-im/status-mobile#21501