-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat_: integrate base chain #6228
base: develop
Are you sure you want to change the base?
Changes from all commits
e3a1106
ae6ed62
a5ca62d
ba2133b
5f7e4a0
1e4b20e
db54ca4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1527,8 +1527,10 @@ func TestWalletConfigOnLoginAccount(t *testing.T) { | |
alchemyArbitrumSepoliaToken := "alchemy-arbitrum-sepolia-token" | ||
alchemyOptimismMainnetToken := "alchemy-optimism-mainnet-token" | ||
alchemyOptimismSepoliaToken := "alchemy-optimism-sepolia-token" | ||
raribleMainnetAPIKey := "rarible-mainnet-api-key" // nolint: gosec | ||
raribleTestnetAPIKey := "rarible-testnet-api-key" // nolint: gosec | ||
alchemyBaseMainnetToken := "alchemy-base-mainnet-token" // nolint: gosec | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alchemy is no longer doing this "one key per chain" nonsense (see https://www.alchemy.com/blog/summer-of-chains#simplifying-multichain-development), we should be able to use just a single key for all chains, no need to add more. I guess you can just take any from the map until we rework this? We should now probably have a single |
||
alchemyBaseSepoliaToken := "alchemy-base-sepolia-token" // nolint: gosec | ||
raribleMainnetAPIKey := "rarible-mainnet-api-key" // nolint: gosec | ||
raribleTestnetAPIKey := "rarible-testnet-api-key" // nolint: gosec | ||
|
||
b := NewGethStatusBackend(tt.MustCreateTestLogger()) | ||
createAccountRequest := &requests.CreateAccount{ | ||
|
@@ -1565,6 +1567,8 @@ func TestWalletConfigOnLoginAccount(t *testing.T) { | |
AlchemyArbitrumSepoliaToken: alchemyArbitrumSepoliaToken, | ||
AlchemyOptimismMainnetToken: alchemyOptimismMainnetToken, | ||
AlchemyOptimismSepoliaToken: alchemyOptimismSepoliaToken, | ||
AlchemyBaseMainnetToken: alchemyBaseMainnetToken, | ||
AlchemyBaseSepoliaToken: alchemyBaseSepoliaToken, | ||
RaribleMainnetAPIKey: raribleMainnetAPIKey, | ||
RaribleTestnetAPIKey: raribleTestnetAPIKey, | ||
}, | ||
|
@@ -1585,6 +1589,8 @@ func TestWalletConfigOnLoginAccount(t *testing.T) { | |
require.Equal(t, b.config.WalletConfig.AlchemyAPIKeys[ArbitrumSepoliaChainID], alchemyArbitrumSepoliaToken) | ||
require.Equal(t, b.config.WalletConfig.AlchemyAPIKeys[OptimismChainID], alchemyOptimismMainnetToken) | ||
require.Equal(t, b.config.WalletConfig.AlchemyAPIKeys[OptimismSepoliaChainID], alchemyOptimismSepoliaToken) | ||
require.Equal(t, b.config.WalletConfig.AlchemyAPIKeys[BaseChainID], alchemyBaseMainnetToken) | ||
require.Equal(t, b.config.WalletConfig.AlchemyAPIKeys[BaseSepoliaChainID], alchemyBaseSepoliaToken) | ||
require.Equal(t, b.config.WalletConfig.RaribleMainnetAPIKey, raribleMainnetAPIKey) | ||
require.Equal(t, b.config.WalletConfig.RaribleTestnetAPIKey, raribleTestnetAPIKey) | ||
|
||
|
@@ -1846,6 +1852,8 @@ func TestRestoreKeycardAccountAndLogin(t *testing.T) { | |
"alchemyArbitrumSepoliaToken": "", | ||
"alchemyOptimismMainnetToken": "", | ||
"alchemyOptimismSepoliaToken": "", | ||
"alchemyBaseMainnetToken": "", | ||
"alchemyBaseSepoliaToken": "", | ||
}, | ||
"torrentConfigEnabled": false, | ||
"torrentConfigPort": 0, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,9 +12,11 @@ var contractDataByChainID = map[uint64]common.Address{ | |
1: common.HexToAddress("0x040EA8bFE441597849A9456182fa46D38B75BC05"), // mainnet | ||
10: common.HexToAddress("0x55bD303eA3D50FC982A8a5b43972d7f38D129bbF"), // optimism | ||
42161: common.HexToAddress("0x54764eF12d29b249fDC7FC3caDc039955A396A8e"), // arbitrum | ||
8453: common.HexToAddress("0x84A1C94fcc5EcFA292771f6aE7Fbf24ec062D34e"), // base | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should stop manually entering chainIDs and just use the wallet constants |
||
11155111: common.HexToAddress("0x55bD303eA3D50FC982A8a5b43972d7f38D129bbF"), // sepolia | ||
421614: common.HexToAddress("0x54764eF12d29b249fDC7FC3caDc039955A396A8e"), // sepolia arbitrum | ||
11155420: common.HexToAddress("0x55bD303eA3D50FC982A8a5b43972d7f38D129bbF"), // sepolia optimism | ||
84532: common.HexToAddress("0x84A1C94fcc5EcFA292771f6aE7Fbf24ec062D34e"), // sepolia base | ||
777333: common.HexToAddress("0x0000000000000000000000000000000010777333"), // unit tests | ||
} | ||
|
||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm @igor-sirotin it seems there's some auto-generated code that's not getting auto-excluded, is there some other place where this needs to be added?