chore(wallet-community)_: Move community minting airdrop to router #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (208)
|
|
Next step is to remove the code below and related functions, that should be on the wallet service to take care of transactions. 
|
saledjenic
changed the title
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
5 times, most recently
from
45dd4c2 to
00a5a5f
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
6 times, most recently
from
78f7468 to
2757af4
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
3 times, most recently
from
5c0877e to
8c002e3
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
3 times, most recently
from
559773a to
87cf27f
Compare
saledjenic
requested review from
a team,
iurimatias and
jrainville
and removed request for
a team
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (21.73%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## move-community-minting-airdrop-to-router-pre-step-2 #6196 +/- ##
========================================================================================
+ Coverage 0 61.86% +61.86%
========================================================================================
Files 0 849 +849
Lines 0 111406 +111406
========================================================================================
+ Hits 0 68918 +68918
- Misses 0 34514 +34514
- Partials 0 7974 +7974
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
87cf27f to
3394343
Compare
|
Could you change the base to be on top of #6261, that way we don't have to review that commit twice. Thanks |
saledjenic
changed the base branch from
develop
to
move-community-minting-airdrop-to-router-pre-step-1
saledjenic
changed the base branch from
move-community-minting-airdrop-to-router-pre-step-1
to
move-community-minting-airdrop-to-router-pre-step-2
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-2
branch
from
3394343 to
37aeb40
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
6dcc4bd to
d442b09
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-2
branch
from
37aeb40 to
68b2bae
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
d442b09 to
e958ef0
Compare
igor-sirotin
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I am sorry @saledjenic. I'm approving, but I didn't really read the code.
I've never seen this community tokens code before, neither I know the wallet code. Investigating huge changes in the code that's new to me makes no sense. I will spend too much time and doubt I'll find a single bug (I tried though).
|
|
||
| func NewCommunityTokensContractMakerMaker(client rpc.ClientInterface) (*CommunityTokensContractMaker, error) { | ||
| if client == nil { | ||
| return nil, errors.New("could not initialize CommunityTokensContractMaker with an rpc client") |
There was a problem hiding this comment.
Suggested change
| return nil, errors.New("could not initialize CommunityTokensContractMaker with an rpc client") | |
| return nil, errors.New("rpc client is required") |
services/communitytokens/service.go
Outdated
| @@ -142,7 +142,7 @@ func (s *Service) handleWalletEvent(event walletevent.Event) { | |||
| errorStr = tokenErr.Error() | |||
| } | |||
|
|
|||
| signal.SendCommunityTokenTransactionStatusSignal(string(pendingTransaction.Type), p.Status == transactions.Success, pendingTransaction.Hash, | |||
| signal.SendCommunityTokenTransactionStatusSignal(0, p.Status == transactions.Success, pendingTransaction.Hash, | |||
There was a problem hiding this comment.
What is 0? Can we please define this as constant?
There was a problem hiding this comment.
Hey, that's most likely due to selecting lines that will go to this PR. You can see that it looks differently in the follow-up PR, here https://github.com/status-im/status-go/pull/6263/files#diff-e86ab0fc741a1f8cf5d8ac362ce33a75e1eaff3fc2bf142671291cccc5da087cR142
transactions/transactor.go
Outdated
Comment on lines
195
to
203
| var toAddress common.Address | ||
| if tx.To() != nil { | ||
| toAddress = *tx.To() | ||
| } else { | ||
| toAddr := crypto.CreateAddress(types.Address(from), tx.Nonce()) | ||
| toAddress = common.Address(toAddr) | ||
| } |
There was a problem hiding this comment.
Can you please add a comment to the code why we do this?
Maybe it's because I'm not from the wallet world, but I don't get the logic.
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-2
branch
from
68b2bae to
587ca54
Compare
…outer - new file `contracts/community-tokens/contracts.go` added to unify contracts creation - the following community related path processors added: - `CommunityBurnProcessor` - `CommunityDeployAssetsProcessor` - `CommunityDeployCollectiblesProcessor` - `CommunityDeployOwnerTokenProcessor` - `CommunityMintTokensProcessor` - `CommunityRemoteBurnProcessor` - `CommunitySetSignerPubKeyProcessor` - `SendType` extended with appropriate options - added endpoints to duplicated `communitytokens` api: - `StoreDeployedCollectibles` - `StoreDeployedOwnerToken` - `StoreDeployedAssets` - removed endpoints from duplicated `communitytokens` api: - `DeployCollectibles` - `DeployOwnerToken` - `ReTrackOwnerTokenDeploymentTransaction` - `DeployAssets` - `DeployCollectiblesEstimate` - `DeployAssetsEstimate` - `DeployOwnerTokenEstimate` - `EstimateMintTokens` - `EstimateRemoteBurn` - `EstimateBurn` - `EstimateSetSignerPubKey` - `NewOwnerTokenInstance` - `NewCommunityTokenDeployerInstance` - `NewCommunityOwnerTokenRegistryInstance` - `NewCollectiblesInstance` - `NewAssetsInstance` - `MintTokens` - `RemoteBurn` - `GetCollectiblesContractInstance` - `GetAssetContractInstance` - `Burn` - `SetSignerPubKey` - `Path` type extended with new property: - `UsedContractAddress` - an address of the contract that will be used for the transaction
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
e958ef0 to
45fb56c
Compare
dlipicar
reviewed
Jan 29, 2025
| @@ -483,13 +121,9 @@ func (api *API) SafeGetOwnerTokenAddress(ctx context.Context, chainID uint64, co | |||
| return api.s.SafeGetOwnerTokenAddress(ctx, chainID, communityID) | |||
| } | |||
|
|
|||
| func (api *API) SetSignerPubKey(ctx context.Context, chainID uint64, contractAddress string, txArgs wallettypes.SendTxArgs, password string, newSignerPubKey string) (string, error) { | |||
There was a problem hiding this comment.
I see this disappeared, was it not used in the client?
There was a problem hiding this comment.
@dlipicar correct, it's not used as an explicit API endpoint but goes over the router now.
alaibe
approved these changes
Jan 29, 2025
This is a breaking change which removes `communitytokens` package. This commit removes old `communitytokens` package, cause previously added `communitytokensv2` package, which is in use now, will be renamed to `communitytokens` in next commit.
This is a breaking change which renames `communitytokensv2` package to `communitytokens`.
saledjenic
merged commit 805e77f
into
move-community-minting-airdrop-to-router-pre-step-2
2 of 10 checks passed
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR in moving community-related transactions from
communitytokenstowalletservice and aligning the sending flow across the app.Related PRs:
Changes done in this PR:
new file
contracts/community-tokens/contracts.goadded to unify contracts creationthe following community related path processors added:
CommunityBurnProcessorCommunityDeployAssetsProcessorCommunityDeployCollectiblesProcessorCommunityDeployOwnerTokenProcessorCommunityMintTokensProcessorCommunityRemoteBurnProcessorCommunitySetSignerPubKeyProcessorSendTypeextended with appropriate optionsadded endpoints to duplicated
communitytokensAPI:StoreDeployedCollectiblesStoreDeployedOwnerTokenStoreDeployedAssetsremoved endpoints from duplicated
communitytokensAPI:DeployCollectiblesDeployOwnerTokenReTrackOwnerTokenDeploymentTransactionDeployAssetsDeployCollectiblesEstimateDeployAssetsEstimateDeployOwnerTokenEstimateEstimateMintTokensEstimateRemoteBurnEstimateBurnEstimateSetSignerPubKeyNewOwnerTokenInstanceNewCommunityTokenDeployerInstanceNewCommunityOwnerTokenRegistryInstanceNewCollectiblesInstanceNewAssetsInstanceMintTokensRemoteBurnGetCollectiblesContractInstanceGetAssetContractInstanceBurnSetSignerPubKeyPathtype extended with new property:UsedContractAddress- an address of the contract that will be used for the transaction