fix(tests)_: prevent crash when creating wakuv2 from multiple goroutines #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating wakuv2 from multiple goroutines results in a race condition where multiple in-memory databases with the same name are attempted to be opened.
Jenkins Builds
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5902 +/- ##
==========================================
Coverage ? 46.10%
==========================================
Files ? 891
Lines ? 158064
Branches ? 0
==========================================
Hits ? 72882
Misses ? 76822
Partials ? 8360
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
approved these changes
Oct 1, 2024
dlipicar
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating wakuv2 from multiple goroutines results in a race condition where multiple in-memory databases with the same name are attempted to be opened