Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: remove waku go generate instructions as unused #5892

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

igor-sirotin
Copy link
Collaborator

Removed some unused legacy //go:generate commands. Didn't even find the output files in the repo.

Required for #5878

@status-im-auto
Copy link
Member

status-im-auto commented Sep 30, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e7ca80a #1 2024-09-30 11:24:55 ~2 min tests-rpc 📄log
✔️ e7ca80a #1 2024-09-30 11:25:58 ~4 min linux 📦zip
✔️ e7ca80a #1 2024-09-30 11:26:40 ~4 min android 📦aar
✔️ e7ca80a #1 2024-09-30 11:26:47 ~4 min ios 📦zip
✔️ e7ca80a #1 2024-09-30 11:54:38 ~32 min tests 📄log

@codecov-commenter
Copy link

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2800 1 2799 29
View the full list of 1 ❄️ flaky tests
github.com/status-im/status-go/mobile TestInitLogging

Flake rate in main: 94.18% (Passed 27 times, Failed 437 times)

Stack Traces | 3.21s run time
=== RUN   TestInitLogging
    init_logging_test.go:17: temp dir: .../jenkins/workspace/status-go_prs_tests_PR-5892@tmp/TestInitLogging4103983309/001
    init_logging_test.go:42: 
        	Error Trace:	.../jenkins/workspace/status-go_prs_tests_PR-5892/mobile/init_logging_test.go:42
        	Error:      	"{\"jsonrpc\":\"2.0\",\"id\":1,\"result\":{\"address\":\"0x51606f00380477c7fb91c0d3d935fc8a3fad1498\",\"currency\":\"usd\",\"networks/current-network\":\"\",\"dapps-address\":\"0x473afb1941bcade965ceb01b09f44c094464cb9c\",\"device-name\":\"\",\"display-name\":\"some-display-name\",\"eip1581-address\":\"0x9539265d6fbcb24354d3b4edc8fd59cd1b14f8b8\",\"installation-id\":\"c06e9a91-efc8-41f8-8256-930d59f6605c\",\"key-uid\":\"0x9b6059977d12b83f6fc8891f89844737d251880dd7784c2a8406f610a84dea43\",\"latest-derived-path\":0,\"link-preview-request-enabled\":true,\"messages-from-contacts-only\":false,\"mnemonic\":\"reject check female axis inspire sport result later pupil error lunar bargain\",\"mutual-contact-enabled?\":false,\"name\":\"Weighty Spiffy Towhee\",\"networks/networks\":[],\"photo-path\":\"\",\"preview-privacy?\":false,\"public-key\":\"0x04a1f1be9bfd0cb9e73b38df6b8181287cc213f68693aa1f5f1d0d79a2fbbd3e3dcfed7551afe90e179ba12e527af4c5d22cb4fa94ce60a443b0e2f3d4db0d19f3\",\"signing-phrase\":\"rake save tuba\",\"default-sync-period\":777600,\"send-push-notifications?\":true,\"appearance\":0,\"profile-pictures-show-to\":2,\"profile-pictures-visibility\":2,\"use-mailservers?\":true,\"wallet-root-address\":\"0xf85ea719f10b48415c9968a602956303ad53e0d0\",\"send-status-updates?\":true,\"current-user-status\":{\"publicKey\":\"0x04a1f1be9bfd0cb9e73b38df6b8181287cc213f68693aa1f5f1d0d79a2fbbd3e3dcfed7551afe90e179ba12e527af4c5d22cb4fa94ce60a443b0e2f3d4db0d19f3\",\"statusType\":1,\"clock\":0,\"text\":\"\"},\"gifs/recent-gifs\":null,\"gifs/favorite-gifs\":null,\"last-backup\":1727695599,\"backup-enabled?\":true,\"gifs/api-key\":\"\",\"show-community-asset-when-sending-tokens?\":true,\"display-assets-below-balance-threshold\":100000000,\"url-unfurling-mode\":1,\"compressedKey\":\"zQ3shqYGZprnpH3nDYvVnGeJSEGokYabErVjUHjngTxxirw2L\",\"emojiHash\":[\"💅🏼\",\"🤤\",\"👩🏽\u200d🦽\",\"👨\u200d🚒\",\"😮\",\"🙋🏻\u200d♂️\",\"👶🏿\",\"🧑🏻\u200d🌾\",\"🧜🏿\",\"🙎🏾\",\"🧑🏿\u200d🔧\",\"🚶\",\"💤\",\"💱\"]}}" should not contain "error"
        	Test:       	TestInitLogging
--- FAIL: TestInitLogging (3.21s)


To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@igor-sirotin igor-sirotin merged commit 5500fa0 into develop Sep 30, 2024
12 checks passed
@igor-sirotin igor-sirotin deleted the chore/remove-unused-waku-generate branch September 30, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants