tests for transaction improvements #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (15)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## transaction-improvements #5879 +/- ##
=============================================================
- Coverage 45.83% 12.05% -33.78%
=============================================================
Files 887 837 -50
Lines 157835 151692 -6143
=============================================================
- Hits 72343 18291 -54052
- Misses 77174 131181 +54007
+ Partials 8318 2220 -6098
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
force-pushed
the
transaction-improvements
branch
2 times, most recently
from
12ae74a to
54f971c
Compare
saledjenic
force-pushed
the
tests-transaction-improvements
branch
from
6d01cfe to
48f5b9d
Compare
antdanchenko
requested review from
yevh-berdnyk,
saledjenic,
glitchminer and
igor-sirotin
saledjenic
force-pushed
the
tests-transaction-improvements
branch
from
740fef6 to
68db02c
Compare
saledjenic
approved these changes
Sep 27, 2024
| "tokenID": "ETH", | ||
| "tokenIDIsOwnerToken": False, | ||
| "toTokenID": "", | ||
| "disabledFromChainIDs": [10, 42161], |
There was a problem hiding this comment.
@antdanchenko since we're resolving selected chains based on the entry in the networks table, and since the statusgo is run with the config set in integration-tests/config.json (that provides config for the Anvil chain only), the result will be the same either we provide an empty list here or the list with all but the Anvil chain id.
There was a problem hiding this comment.
thanks for the note, we will add more anvil networks and bridges in future to simulate proper route, but for now let's keep as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test to build transaction from router on anvil using signals
